Bug 214542 - WebPageProxyIdentifier parameter of WebPageProxy::CreateNewPage() should not be Optional
Summary: WebPageProxyIdentifier parameter of WebPageProxy::CreateNewPage() should not ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-19 20:04 PDT by David Kilzer (:ddkilzer)
Modified: 2020-07-20 08:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch v1 (5.05 KB, patch)
2020-07-19 20:07 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-07-19 20:04:48 PDT 
WebPageProxyIdentifier parameter of WebPageProxy::CreateNewPage() should not be Optional.

The method extracts the value of Optional<WebPageProxyIdentifier> unconditionally, so it's clear it doesn't need to be Optional<>.

<rdar://problem/65768644>
Comment 1 David Kilzer (:ddkilzer) 2020-07-19 20:07:59 PDT 
Created attachment 404695 [details]
Patch v1
Comment 2 EWS 2020-07-20 08:17:30 PDT 
Committed r264602: <https://trac.webkit.org/changeset/264602>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404695 [details].