Bug 214537 - AccessibilityTable::isDataTable() compares the Color::alphaByte() value to 1, but probably wants to be comparing it to 255
Summary: AccessibilityTable::isDataTable() compares the Color::alphaByte() value to 1,...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-19 11:14 PDT by Sam Weinig
Modified: 2020-07-19 11:15 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-07-19 11:14:22 PDT 
While doing some refactoring, changing Color::alpha() to be named Color::alphaByte() to clarify it returns a 0-255 based value, I spotted a use in AccessibilityTable::isDataTable() that compares the Color::alphaByte() value to 1, but probably wants to be comparing it to 255 (or checking isOpaque()).

We should verify that assumption, fix it and add a test.
Comment 1 Radar WebKit Bug Importer 2020-07-19 11:14:33 PDT 
<rdar://problem/65793228>
Comment 2 Sam Weinig 2020-07-19 11:14:56 PDT 
Adding James and Chris.
Comment 3 Radar WebKit Bug Importer 2020-07-19 11:15:03 PDT 
<rdar://problem/65793254>