WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
214537
AccessibilityTable::isDataTable() compares the Color::alphaByte() value to 1, but probably wants to be comparing it to 255
https://bugs.webkit.org/show_bug.cgi?id=214537
Summary
AccessibilityTable::isDataTable() compares the Color::alphaByte() value to 1,...
Sam Weinig
Reported
2020-07-19 11:14:22 PDT
While doing some refactoring, changing Color::alpha() to be named Color::alphaByte() to clarify it returns a 0-255 based value, I spotted a use in AccessibilityTable::isDataTable() that compares the Color::alphaByte() value to 1, but probably wants to be comparing it to 255 (or checking isOpaque()). We should verify that assumption, fix it and add a test.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-07-19 11:14:33 PDT
<
rdar://problem/65793228
>
Sam Weinig
Comment 2
2020-07-19 11:14:56 PDT
Adding James and Chris.
Radar WebKit Bug Importer
Comment 3
2020-07-19 11:15:03 PDT
<
rdar://problem/65793254
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug