Bug 214527 - [LFC][IFC] Move inline run alignment logic to a dedicated class
Summary: [LFC][IFC] Move inline run alignment logic to a dedicated class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: LFC 215752
  Show dependency tree / graph
 
Reported: 2020-07-18 20:45 PDT by zalan
Modified: 2020-08-26 09:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (41.79 KB, patch)
2020-07-18 20:50 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (40.71 KB, patch)
2020-07-18 21:12 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (36.85 KB, patch)
2020-07-31 03:51 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (37.21 KB, patch)
2020-08-25 20:35 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (37.12 KB, patch)
2020-08-26 06:25 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (36.55 KB, patch)
2020-08-26 07:52 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-07-18 20:45:11 PDT 
ssia
Comment 1 zalan 2020-07-18 20:50:29 PDT 
Created attachment 404652 [details]
Patch
Comment 2 zalan 2020-07-18 20:59:12 PDT 
Comment on attachment 404652 [details]
Patch

oops, "vertical-align: middle" logic got in here.
Comment 3 zalan 2020-07-18 21:12:12 PDT 
Created attachment 404653 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2020-07-25 20:46:17 PDT 
<rdar://problem/66115796>
Comment 5 zalan 2020-07-31 03:51:27 PDT 
Created attachment 405680 [details]
Patch
Comment 6 zalan 2020-08-25 20:35:04 PDT 
Created attachment 407269 [details]
Patch
Comment 7 zalan 2020-08-26 06:25:10 PDT 
Created attachment 407293 [details]
Patch
Comment 8 zalan 2020-08-26 07:52:16 PDT 
Created attachment 407297 [details]
Patch
Comment 9 Antti Koivisto 2020-08-26 09:25:47 PDT 
Comment on attachment 407297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407297&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:67
> +class LineContentAligner {

Might it deserve a file of its own?
Comment 10 zalan 2020-08-26 09:27:42 PDT 
(In reply to Antti Koivisto from comment #9)
> Comment on attachment 407297 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=407297&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:67
> > +class LineContentAligner {
> 
> Might it deserve a file of its own?
It's coming!
Comment 11 EWS 2020-08-26 09:46:08 PDT 
Committed r266169: <https://trac.webkit.org/changeset/266169>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407297 [details].