Bug 214526 - Fixed regression due to r264507: Math.{min|max} inequality test should use DoubleNotEqualOrUnordered instead DoubleNotEqualAndOrdered.
Summary: Fixed regression due to r264507: Math.{min|max} inequality test should use Do...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-18 18:32 PDT by Mark Lam
Modified: 2020-07-18 21:25 PDT (History)
8 users (show)

See Also:


Attachments
proposed patch. (6.69 KB, patch)
2020-07-18 18:46 PDT, Mark Lam
ysuzuki: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-07-18 18:32:17 PDT
This bug resulted in NaNs being handled by the "equal" case in some scenarios.
Comment 1 Radar WebKit Bug Importer 2020-07-18 18:32:57 PDT
<rdar://problem/65778061>
Comment 2 Mark Lam 2020-07-18 18:46:58 PDT
Created attachment 404650 [details]
proposed patch.
Comment 3 Yusuke Suzuki 2020-07-18 19:08:58 PDT
Comment on attachment 404650 [details]
proposed patch.

r=me
Comment 4 Mark Lam 2020-07-18 21:25:03 PDT
Thanks for the review.  Landed in r264575: <http://trac.webkit.org/r264575>.