Fixes to match BaseAudioContext.idl to spec

[Clark Wang]

Added in small fixes to bring BaseAudioContext.idl closer to spec. Edited a test file for PannerNode constructor to match spec and Chrome / Firefox.

[Clark Wang]

Created attachment 404592 [details]
Patch

[Clark Wang]

Created attachment 404593 [details]
Patch

[Chris Dumez]

Comment on attachment 404593 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404593&action=review

> Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:-526
> -    return PannerNode::create(*this, sampleRate());

So who is using this old factory / constructor now? If no one is, then why aren't you removing it in this patch? We don't want to keep dead code around, especially dead code that is not spec-compliant.

[Clark Wang]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 404593 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404593&action=review
> 
> > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:-526
> > -    return PannerNode::create(*this, sampleRate());
> 
> So who is using this old factory / constructor now? If no one is, then why
> aren't you removing it in this patch? We don't want to keep dead code
> around, especially dead code that is not spec-compliant.

I think WebKitAudioPannerNode is still using PannerNodeBase, but otherwise I can remove old PannerNode constructor.

[Clark Wang]

Created attachment 404720 [details]
Patch

[Clark Wang]

Created attachment 404740 [details]
Patch

[EWS]

Committed r264620: <https://trac.webkit.org/changeset/264620>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404740 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65849546>