RESOLVED FIXED Bug 214451
Only use enum classes in HTTPParsers 
https://bugs.webkit.org/show_bug.cgi?id=214451
Summary Only use enum classes in HTTPParsers
Rob Buis
Reported 2020-07-17 04:58:02 PDT
Make ContentTypeOptionsDisposition an enum class since it is more readable.
Attachments
Patch (14.23 KB, patch)
2020-07-17 06:43 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (14.18 KB, patch)
2020-07-18 01:18 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-07-17 06:43:51 PDT
Created attachment 404557 [details] Patch
Darin Adler
Comment 2 2020-07-17 20:09:05 PDT
Comment on attachment 404557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404557&action=review > Source/WebCore/platform/network/HTTPParsers.h:50 > +enum class ContentTypeOptionsDisposition { Could you add a base type? Maybe bool or uint8_t. > Source/WebCore/platform/network/HTTPParsers.h:55 > +enum class XFrameOptionsDisposition { Here too.
Rob Buis
Comment 3 2020-07-18 01:18:31 PDT
Created attachment 404639 [details] Patch
EWS
Comment 4 2020-07-18 03:33:59 PDT
Committed r264566: <https://trac.webkit.org/changeset/264566> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404639 [details].
Radar WebKit Bug Importer
Comment 5 2020-07-18 03:34:13 PDT
<rdar://problem/65763910>
Note You need to log in before you can comment on or make changes to this bug.