Bug 214451 - Only use enum classes in HTTPParsers
Summary: Only use enum classes in HTTPParsers
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
Keywords: InRadar
Depends on:
Reported: 2020-07-17 04:58 PDT by Rob Buis
Modified: 2020-07-18 03:34 PDT (History)
5 users (show)

See Also:

Patch (14.23 KB, patch)
2020-07-17 06:43 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (14.18 KB, patch)
2020-07-18 01:18 PDT, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-07-17 04:58:02 PDT
Make ContentTypeOptionsDisposition an enum class since it is more readable.
Comment 1 Rob Buis 2020-07-17 06:43:51 PDT
Created attachment 404557 [details]
Comment 2 Darin Adler 2020-07-17 20:09:05 PDT
Comment on attachment 404557 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=404557&action=review

> Source/WebCore/platform/network/HTTPParsers.h:50
> +enum class ContentTypeOptionsDisposition {

Could you add a base type? Maybe bool or uint8_t.

> Source/WebCore/platform/network/HTTPParsers.h:55
> +enum class XFrameOptionsDisposition {

Here too.
Comment 3 Rob Buis 2020-07-18 01:18:31 PDT
Created attachment 404639 [details]
Comment 4 EWS 2020-07-18 03:33:59 PDT
Committed r264566: <https://trac.webkit.org/changeset/264566>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404639 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-18 03:34:13 PDT