Bug 214447 - GenerateCertificateAsync should be called on signaling thread
Summary: GenerateCertificateAsync should be called on signaling thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-17 00:25 PDT by Sihui Liu
Modified: 2020-07-20 09:59 PDT (History)
14 users (show)

See Also:

Attachments
Patch (10.72 KB, patch)
2020-07-17 00:35 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (5.94 KB, patch)
2020-07-20 02:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-07-17 00:25:23 PDT 
...
Comment 1 Sihui Liu 2020-07-17 00:35:26 PDT 
Created attachment 404545 [details]
Patch
Comment 2 Sihui Liu 2020-07-17 09:53:30 PDT 
The added test would crash:
# Fatal error in: /Volumes/Data/worker/macOS-Mojave-Debug-Build-EWS/build/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/rtc_certificate_generator.cc, line 147
# last system error: 2
# Check failed: signaling_thread_->IsCurrent()
Comment 3 Alexey Proskuryakov 2020-07-18 11:24:24 PDT 
Is this a duplicate of bug 214478? This was filed earlier, but that one is more comprehensive, listing more affected tests.
Comment 4 youenn fablet 2020-07-20 02:15:25 PDT 
Created attachment 404703 [details]
Patch
Comment 5 Geoffrey Garen 2020-07-20 09:26:29 PDT 
Comment on attachment 404703 [details]
Patch

r=me
Comment 6 Geoffrey Garen 2020-07-20 09:27:26 PDT 
Do we need to unskip storage/indexeddb/structured-clone-rtccertificate now?
Comment 7 youenn fablet 2020-07-20 09:52:59 PDT 
(In reply to Geoffrey Garen from comment #6)
> Do we need to unskip storage/indexeddb/structured-clone-rtccertificate now?

LayoutTests/storage/indexeddb/structured-clone.html does not contain any RTCCertificate use (after https://bugs.webkit.org/show_bug.cgi?id=214481) so it should no longer crash. We probably forgot to reenable it.

We should probably readd RTCCertificate in the test and reenable it at the same time.
Comment 8 EWS 2020-07-20 09:58:18 PDT 
Committed r264604: <https://trac.webkit.org/changeset/264604>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404703 [details].
Comment 9 Radar WebKit Bug Importer 2020-07-20 09:59:25 PDT 
<rdar://problem/65831740>