Bug 214445 – Add a addition point for extra user media sandbox extensions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Add a addition point for extra user media sandbox extensions

[Tim Horton]

Created attachment 404540 [details]
Patch

[Tim Horton]

<rdar://problem/65148262>

[Sam Weinig]

Comment on attachment 404540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404540&action=review

> Source/WebKit/UIProcess/UserMediaProcessManager.cpp:111
> +    if (needsAppleCameraSandboxExtension) {
>          extensionCount++;
> +#if HAVE(ADDITIONAL_APPLE_CAMERA_SERVICE)
> +        extensionCount++;
> +#endif
> +    }

I wonder if all this nonsense can be removed if we just modernized the Handle and HandleArray code. I would bet (though don't really remember) it stems from a time pre-move-only types, and now could probably be a lot more sane.

[Anders Carlsson]

(In reply to Sam Weinig from comment #3)

> I wonder if all this nonsense can be removed if we just modernized the
> Handle and HandleArray code. I would bet (though don't really remember) it
> stems from a time pre-move-only types, and now could probably be a lot more
> sane.

Yup.

[Tim Horton]

Comment on attachment 404540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404540&action=review

>> Source/WebKit/UIProcess/UserMediaProcessManager.cpp:111
>> +    }
> 
> I wonder if all this nonsense can be removed if we just modernized the Handle and HandleArray code. I would bet (though don't really remember) it stems from a time pre-move-only types, and now could probably be a lot more sane.

Heh, I wondered (and complained to others!) about why it was written like this; that makes sense. Not to be fixed in this patch, though.

[EWS]

Committed r264521: <https://trac.webkit.org/changeset/264521>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404540 [details].