Bug 214445 - Add a addition point for extra user media sandbox extensions
Summary: Add a addition point for extra user media sandbox extensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-17 00:03 PDT by Tim Horton
Modified: 2020-07-17 11:24 PDT (History)
13 users (show)

See Also:

Attachments
Patch (4.21 KB, patch)
2020-07-17 00:03 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-07-17 00:03:20 PDT 
Add a addition point for extra user media sandbox extensions
Comment 1 Tim Horton 2020-07-17 00:03:53 PDT 
Created attachment 404540 [details]
Patch
Comment 2 Tim Horton 2020-07-17 00:03:55 PDT 
<rdar://problem/65148262>
Comment 3 Sam Weinig 2020-07-17 09:00:43 PDT 
Comment on attachment 404540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404540&action=review

> Source/WebKit/UIProcess/UserMediaProcessManager.cpp:111
> +    if (needsAppleCameraSandboxExtension) {
>          extensionCount++;
> +#if HAVE(ADDITIONAL_APPLE_CAMERA_SERVICE)
> +        extensionCount++;
> +#endif
> +    }

I wonder if all this nonsense can be removed if we just modernized the Handle and HandleArray code. I would bet (though don't really remember) it stems from a time pre-move-only types, and now could probably be a lot more sane.
Comment 4 Anders Carlsson 2020-07-17 09:08:30 PDT 
(In reply to Sam Weinig from comment #3)

> I wonder if all this nonsense can be removed if we just modernized the
> Handle and HandleArray code. I would bet (though don't really remember) it
> stems from a time pre-move-only types, and now could probably be a lot more
> sane.

Yup.
Comment 5 Tim Horton 2020-07-17 10:52:51 PDT 
Comment on attachment 404540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404540&action=review

>> Source/WebKit/UIProcess/UserMediaProcessManager.cpp:111
>> +    }
> 
> I wonder if all this nonsense can be removed if we just modernized the Handle and HandleArray code. I would bet (though don't really remember) it stems from a time pre-move-only types, and now could probably be a lot more sane.

Heh, I wondered (and complained to others!) about why it was written like this; that makes sense. Not to be fixed in this patch, though.
Comment 6 EWS 2020-07-17 11:24:49 PDT 
Committed r264521: <https://trac.webkit.org/changeset/264521>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404540 [details].