Bug 214443 - emitIsUndefined() should not special-case [[IsHTMLDDA]] objects
Summary: emitIsUndefined() should not special-case [[IsHTMLDDA]] objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Trivial
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-16 20:41 PDT by Alexey Shvayka
Modified: 2020-08-17 09:36 PDT (History)
8 users (show)

See Also:


Attachments
Patch (35.27 KB, patch)
2020-07-16 20:44 PDT, Alexey Shvayka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2020-07-16 20:41:36 PDT
emitIsUndefined() should not special-case [[IsHTMLDDA]] objects
Comment 1 Alexey Shvayka 2020-07-16 20:44:01 PDT
Created attachment 404530 [details]
Patch
Comment 2 Alexey Shvayka 2020-07-16 20:44:39 PDT
(In reply to Alexey Shvayka from comment #1)
> Created attachment 404530 [details]
> Patch

Warmed-up runs, --outer 16:

                                             r264388                   patch

default-value-destructuring-array       116.6965+-6.7738     ?    119.2430+-4.7604        ? might be 1.0218x slower
default-value-destructuring-object       67.0743+-2.4654     ^     55.5882+-2.1022        ^ definitely 1.2066x faster
default-value-function-parameters        33.3015+-0.2660     ^     21.8662+-0.2948        ^ definitely 1.5230x faster

<geometric>                              63.7685+-1.2348     ^     52.4954+-1.2752        ^ definitely 1.2147x faster
Comment 3 Yusuke Suzuki 2020-07-16 21:07:35 PDT
Comment on attachment 404530 [details]
Patch

r=me
Comment 4 EWS 2020-07-17 04:55:57 PDT
Committed r264504: <https://trac.webkit.org/changeset/264504>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404530 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-17 04:56:16 PDT
<rdar://problem/65720373>