Bug 21444 - SVGResourceClipper cleanUp
Summary: SVGResourceClipper cleanUp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-07 13:31 PDT by Dirk Schulze
Modified: 2008-11-14 13:42 PST (History)
1 user (show)

See Also:

Attachments
SVG clipping (23.26 KB, patch)
2008-10-07 13:33 PDT, Dirk Schulze 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2008-10-07 13:31:11 PDT 
We can share the code of the different platforms, since it is nearly the same.
Comment 1 Dirk Schulze 2008-10-07 13:33:32 PDT 
Created attachment 24157 [details]
SVG clipping

I made the code platform independent. I tested the patch with Cairo and Qt. Wasn't able to test it for Cg yet.
Comment 2 Eric Seidel (no email) 2008-10-07 13:40:17 PDT 
Comment on attachment 24157 [details]
SVG clipping

This looks fine from a CG perspective.  I'll land it in my tree, run the tests and commit.  Thanks for taking this on.
Comment 3 Adam Barth 2008-10-14 01:26:02 PDT 
Eric, what is the status of this?  Are you going to land it or should someone else?  Assigning to Eric for resolution.
Comment 4 Eric Seidel (no email) 2008-11-14 13:42:35 PST 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	D	WebCore/svg/graphics/cairo/SVGResourceClipperCairo.cpp
	D	WebCore/svg/graphics/cg/SVGResourceClipperCg.cpp
	D	WebCore/svg/graphics/qt/SVGResourceClipperQt.cpp
	M	WebCore/ChangeLog
	M	WebCore/GNUmakefile.am
	M	WebCore/WebCore.pro
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/platform/graphics/GraphicsContext.h
	M	WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
	M	WebCore/platform/graphics/cg/GraphicsContextCG.cpp
	M	WebCore/platform/graphics/qt/GraphicsContextQt.cpp
	M	WebCore/svg/graphics/SVGResourceClipper.cpp
Committed r38405

This will affect our next Chromium merge (in a good way). :)