Bug 214433 - [iOS 14] Some PassKit SPI is now API
Summary: [iOS 14] Some PassKit SPI is now API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-16 16:32 PDT by Jonathan Bedard
Modified: 2020-07-17 08:54 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.49 KB, patch)
2020-07-16 16:44 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (1.58 KB, patch)
2020-07-16 20:48 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2020-07-16 22:27 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-07-16 16:32:58 PDT
There is some PassKit SPI that is API in iOS 14.
Comment 1 Radar WebKit Bug Importer 2020-07-16 16:34:27 PDT
<rdar://problem/65695889>
Comment 2 Jonathan Bedard 2020-07-16 16:44:25 PDT
Created attachment 404495 [details]
Patch
Comment 3 Darin Adler 2020-07-16 16:47:05 PDT
Comment on attachment 404495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404495&action=review

> Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:330
> +#ifndef __PKPAYMENTMERCHANTSESSION_H__

This is not the ideal way to resolve this. Long term we would want to remove this block entirely. Doing it this way means we could end up keeping this forever.
Comment 4 Jonathan Bedard 2020-07-16 17:18:28 PDT
(In reply to Darin Adler from comment #3)
> Comment on attachment 404495 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404495&action=review
> 
> > Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:330
> > +#ifndef __PKPAYMENTMERCHANTSESSION_H__
> 
> This is not the ideal way to resolve this. Long term we would want to remove
> this block entirely. Doing it this way means we could end up keeping this
> forever.

I agree, I only went with it because it will be temporary once we stop building iOS 13.

The other option would be to have version checks for both iOS and watchOS, which seemed worse to me.
Comment 5 Darin Adler 2020-07-16 17:26:51 PDT
Adding both version checks is what would let us remove this eventually. Otherwise we will keep it forever and not remember why it’s there.
Comment 6 Jonathan Bedard 2020-07-16 20:48:05 PDT
Created attachment 404531 [details]
Patch
Comment 7 Jonathan Bedard 2020-07-16 22:27:15 PDT
Created attachment 404537 [details]
Patch
Comment 8 EWS 2020-07-17 07:09:08 PDT
Committed r264506: <https://trac.webkit.org/changeset/264506>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404537 [details].