RESOLVED FIXED 214433
[iOS 14] Some PassKit SPI is now API 
https://bugs.webkit.org/show_bug.cgi?id=214433
Summary [iOS 14] Some PassKit SPI is now API
Jonathan Bedard
Reported 2020-07-16 16:32:58 PDT
There is some PassKit SPI that is API in iOS 14.
Attachments
Patch (1.49 KB, patch)
2020-07-16 16:44 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.58 KB, patch)
2020-07-16 20:48 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2020-07-16 22:27 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-07-16 16:34:27 PDT
<rdar://problem/65695889>
Jonathan Bedard
Comment 2 2020-07-16 16:44:25 PDT
Created attachment 404495 [details] Patch
Darin Adler
Comment 3 2020-07-16 16:47:05 PDT
Comment on attachment 404495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404495&action=review > Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:330 > +#ifndef __PKPAYMENTMERCHANTSESSION_H__ This is not the ideal way to resolve this. Long term we would want to remove this block entirely. Doing it this way means we could end up keeping this forever.
Jonathan Bedard
Comment 4 2020-07-16 17:18:28 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 404495 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404495&action=review > > > Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:330 > > +#ifndef __PKPAYMENTMERCHANTSESSION_H__ > > This is not the ideal way to resolve this. Long term we would want to remove > this block entirely. Doing it this way means we could end up keeping this > forever. I agree, I only went with it because it will be temporary once we stop building iOS 13. The other option would be to have version checks for both iOS and watchOS, which seemed worse to me.
Darin Adler
Comment 5 2020-07-16 17:26:51 PDT
Adding both version checks is what would let us remove this eventually. Otherwise we will keep it forever and not remember why it’s there.
Jonathan Bedard
Comment 6 2020-07-16 20:48:05 PDT
Created attachment 404531 [details] Patch
Jonathan Bedard
Comment 7 2020-07-16 22:27:15 PDT
Created attachment 404537 [details] Patch
EWS
Comment 8 2020-07-17 07:09:08 PDT
Committed r264506: <https://trac.webkit.org/changeset/264506> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404537 [details].
Note You need to log in before you can comment on or make changes to this bug.