Bug 214423 – Make AnyStepHandling an enum class

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Rob Buis]

Make AnyStepHandling an enum class since this is more readable and allows
us to have less includes in header files.

[Rob Buis]

Created attachment 404483 [details]
Patch

[youenn fablet]

Comment on attachment 404483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404483&action=review

> Source/WebCore/html/HTMLInputElement.cpp:2123
> +    StepRange stepRange = createStepRange(AnyStepHandling::Reject);

auto

> Source/WebCore/html/RangeInputType.cpp:208
> +    StepRange stepRange(createStepRange(AnyStepHandling::Reject));

auto stepRange = ...
Ditto below.

[Rob Buis]

Created attachment 404713 [details]
Patch

[EWS]

Committed r264600: <https://trac.webkit.org/changeset/264600>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404713 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65823760>

[Darin Adler]

Comment on attachment 404713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404713&action=review

> Source/WebCore/html/StepRange.h:31
> -enum AnyStepHandling { RejectAny, AnyIsDefaultStep };
> +enum class AnyStepHandling {
> +    Reject,
> +    Default
> +};

Add a : bool here?

I think this was good on a single line, a little disappointed it’s now on multiple lines.

> Source/WebCore/html/StepRange.h:33
>  enum class RangeLimitations {

Ditto.

[Rob Buis]

Reopening to attach new patch.

[Rob Buis]

Created attachment 404727 [details]
Patch

[Darin Adler]

Comment on attachment 404727 [details]
Patch

Also need to add the ": bool" anywhere these are forward declared.

[Rob Buis]

Created attachment 404729 [details]
Patch

[Rob Buis]

(In reply to Darin Adler from comment #9)
> Comment on attachment 404727 [details]
> Patch
> 
> Also need to add the ": bool" anywhere these are forward declared.

Yeah, I was a bit too quick, should be green this time.

[EWS]

Committed r264656: <https://trac.webkit.org/changeset/264656>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404729 [details].