RESOLVED FIXED 214416
Make DocumentParser.ParserState an enum class 
https://bugs.webkit.org/show_bug.cgi?id=214416
Summary Make DocumentParser.ParserState an enum class
Rob Buis
Reported 2020-07-16 11:27:08 PDT
Make DocumentParser.ParserState an enum class since it is more readable.
Attachments
Patch (3.87 KB, patch)
2020-07-16 11:28 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-07-16 11:28:12 PDT
Created attachment 404468 [details] Patch
Darin Adler
Comment 2 2020-07-16 14:22:17 PDT
Comment on attachment 404468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404468&action=review > Source/WebCore/dom/DocumentParser.h:70 > + bool isStopped() const { return m_state >= ParserState::Stopped; } Very sneaky that this one is different from the other three. I wonder if some of the callers who are checking isStopped() actually should be checking !isParsing() instead.
EWS
Comment 3 2020-07-16 23:39:13 PDT
Committed r264501: <https://trac.webkit.org/changeset/264501> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404468 [details].
Radar WebKit Bug Importer
Comment 4 2020-07-16 23:40:17 PDT
<rdar://problem/65710633>
Note You need to log in before you can comment on or make changes to this bug.