Bug 214412 – REGRESSION [ macOS ] fullscreen/video-controls-rtl.html is a flaky failure

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: Media

[Hector Lopez]

fullscreen/video-controls-rtl.html

Test appears to begin flaky failing around r263839

History:
https://results.webkit.org/?suite=layout-tests&test=fullscreen%2Fvideo-controls-rtl.html

Diff:
--- /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fullscreen/video-controls-rtl-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fullscreen/video-controls-rtl-actual.txt
@@ -4,8 +4,8 @@
 EVENT(webkitfullscreenchange)
 EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
 EXPECTED (volumeBox = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-volume-slider-container') != 'null') OK
-EXPECTED (volumeBox.classList.contains('uses-ltr-user-interface-layout-direction') == 'true') OK
-EXPECTED (document.defaultView.getComputedStyle(volumeBox)['transform'] == 'none') OK
+EXPECTED (volumeBox.classList.contains('uses-ltr-user-interface-layout-direction') == 'true'), OBSERVED 'false' FAIL
+EXPECTED (document.defaultView.getComputedStyle(volumeBox)['transform'] == 'none'), OBSERVED 'matrix(-1, 0, 0, 1, 23, 0)' FAIL
 EXPECTED (volumeBox.classList.contains('uses-ltr-user-interface-layout-direction') == 'false') OK
 EXPECTED (document.defaultView.getComputedStyle(volumeBox)['transform'] == 'matrix(-1, 0, 0, 1, 23, 0)') OK
 EXPECTED (volumeBox.classList.contains('uses-ltr-user-interface-layout-direction') == 'true') OK

[Radar WebKit Bug Importer]

<rdar://problem/65672192>

[Hector Lopez]

This test is not reproducing easily

[Alexey Proskuryakov]

This is a enableModernMediaControls=false test, can it be just deleted?

Otherwise, quite mysterious - I don't see a clear culprit in preceding commits. Mysteriousness often indicates a serious issue of some kind.

[Hector Lopez]

This test is also crashing consistently on macOS gpuprocess. 
Assertion failed: m_stack.isEmpty WebCore::GraphicsContext::restore()

Crash log:
No crash log found for GPUProcess:88375.

stdout:

stderr:
ERROR: ERROR void GraphicsContext::restore() stack is empty
./platform/graphics/GraphicsContext.cpp(408) : void WebCore::GraphicsContext::restore()
ASSERTION FAILED: m_stack.isEmpty()
./platform/graphics/GraphicsContext.cpp(375) : WebCore::GraphicsContext::~GraphicsContext()
1   0x13b108329 WTFCrash
2   0x11c29d8eb WTFCrashWithInfo(int, char const*, char const*, int)
3   0x120234ab4 WebCore::GraphicsContext::~GraphicsContext()
4   0x120234bf5 WebCore::GraphicsContext::~GraphicsContext()
5   0x11de3162b std::__1::default_delete<WebCore::GraphicsContext>::operator()(WebCore::GraphicsContext*) const
6   0x11de315af std::__1::unique_ptr<WebCore::GraphicsContext, std::__1::default_delete<WebCore::GraphicsContext> >::reset(WebCore::GraphicsContext*)
7   0x11de31549 std::__1::unique_ptr<WebCore::GraphicsContext, std::__1::default_delete<WebCore::GraphicsContext> >::~unique_ptr()
8   0x11de21385 std::__1::unique_ptr<WebCore::GraphicsContext, std::__1::default_delete<WebCore::GraphicsContext> >::~unique_ptr()
9   0x11de2158a WebCore::IOSurface::~IOSurface()
10  0x11de215b5 WebCore::IOSurface::~IOSurface()
ERROR: ERROR void GraphicsContext::restore() stack is empty
./platform/graphics/GraphicsContext.cpp(408) : void WebCore::GraphicsContext::restore()
11  0x10f0ec9eb std::__1::default_delete<WebCore::IOSurface>::operator()(WebCore::IOSurface*) const
12  0x10f0ec96f std::__1::unique_ptr<WebCore::IOSurface, std::__1::default_delete<WebCore::IOSurface> >::reset(WebCore::IOSurface*)
13  0x10f0ec909 std::__1::unique_ptr<WebCore::IOSurface, std::__1::default_delete<WebCore::IOSurface> >::~unique_ptr()
14  0x10f0d5625 std::__1::unique_ptr<WebCore::IOSurface, std::__1::default_delete<WebCore::IOSurface> >::~unique_ptr()
15  0x10f0e2ee5 WebCore::ImageBufferIOSurfaceBackend::~ImageBufferIOSurfaceBackend()
16  0x10f0e2ea8 WebKit::ImageBufferShareableIOSurfaceBackend::~ImageBufferShareableIOSurfaceBackend()
17  0x10f0e2e55 WebKit::ImageBufferShareableIOSurfaceBackend::~ImageBufferShareableIOSurfaceBackend()
18  0x10f0e2e7c WebKit::ImageBufferShareableIOSurfaceBackend::~ImageBufferShareableIOSurfaceBackend()
19  0x10e1bacbf std::__1::default_delete<WebKit::ImageBufferShareableIOSurfaceBackend>::operator()(WebKit::ImageBufferShareableIOSurfaceBackend*) const
20  0x10e1bac7f std::__1::unique_ptr<WebKit::ImageBufferShareableIOSurfaceBackend, std::__1::default_delete<WebKit::ImageBufferShareableIOSurfaceBackend> >::reset(WebKit::ImageBufferShareableIOSurfaceBackend*)
21  0x10e1bac19 std::__1::unique_ptr<WebKit::ImageBufferShareableIOSurfaceBackend, std::__1::default_delete<WebKit::ImageBufferShareableIOSurfaceBackend> >::~unique_ptr()
22  0x10e1b8b75 std::__1::unique_ptr<WebKit::ImageBufferShareableIOSurfaceBackend, std::__1::default_delete<WebKit::ImageBufferShareableIOSurfaceBackend> >::~unique_ptr()
23  0x10e1ba3a5 WebCore::ConcreteImageBuffer<WebKit::ImageBufferShareableIOSurfaceBackend>::~ConcreteImageBuffer()
24  0x10e1ba544 WebKit::RemoteImageBufferProxy<WebKit::ImageBufferShareableIOSurfaceBackend>::~RemoteImageBufferProxy()
25  0x10e1b8fc5 WebKit::RemoteImageBufferProxy<WebKit::ImageBufferShareableIOSurfaceBackend>::~RemoteImageBufferProxy()
26  0x10e1b8fec WebKit::RemoteImageBufferProxy<WebKit::ImageBufferShareableIOSurfaceBackend>::~RemoteImageBufferProxy()
27  0x10e1b891f std::__1::default_delete<WebKit::RemoteImageBufferMessageHandlerProxy>::operator()(WebKit::RemoteImageBufferMessageHandlerProxy*) const
28  0x10e1b889f std::__1::unique_ptr<WebKit::RemoteImageBufferMessageHandlerProxy, std::__1::default_delete<WebKit::RemoteImageBufferMessageHandlerProxy> >::reset(WebKit::RemoteImageBufferMessageHandlerProxy*)
29  0x10e1b8839 std::__1::unique_ptr<WebKit::RemoteImageBufferMessageHandlerProxy, std::__1::default_delete<WebKit::RemoteImageBufferMessageHandlerProxy> >::~unique_ptr()
30  0x10e1b8815 std::__1::unique_ptr<WebKit::RemoteImageBufferMessageHandlerProxy, std::__1::default_delete<WebKit::RemoteImageBufferMessageHandlerProxy> >::~unique_ptr()
31  0x10e1d1357 WTF::KeyValuePairHashTraits<WTF::HashTraits<WTF::ObjectIdentifier<WebKit::ImageBufferIdentifierType> >, WTF::HashTraits<std::__1::unique_ptr<WebKit::RemoteImageBufferMessageHandlerProxy, std::__1::default_delete<WebKit::RemoteImageBufferMessageHandlerProxy> > > >::customDeleteBucket(WTF::KeyValuePair<WTF::ObjectIdentifier<WebKit::ImageBufferIdentifierType>, std::__1::unique_ptr<WebKit::RemoteImageBufferMessageHandlerProxy, std::__1::default_delete<WebKit::RemoteImageBufferMessageHandlerProxy> > >&)
LEAK: 1 WebPageProxy

[Hector Lopez]

Test expectation while investigated:

https://trac.webkit.org/changeset/265429/webkit

[Ahmad Saleem]

Test is gone: https://github.com/WebKit/WebKit/commit/a39bd42ad87d82a3bea0fa6eac107376a973cf7c

But Comment 03 suggest it might be hiding some other issue, so should we close this or not?

[Ahmad Saleem]

Removed this test here:

https://github.com/WebKit/WebKit/commit/a39bd42ad87d82a3bea0fa6eac107376a973cf7c

Nothing to do here.