Bug 214406 - [LFC][IFC] adjustBaselineAndLineHeight should take the parent inline box.
Summary: [LFC][IFC] adjustBaselineAndLineHeight should take the parent inline box.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: LFC 215752
  Show dependency tree / graph
 
Reported: 2020-07-16 08:19 PDT by zalan
Modified: 2020-08-22 19:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (41.13 KB, patch)
2020-07-16 08:57 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (41.26 KB, patch)
2020-07-16 19:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (41.96 KB, patch)
2020-07-16 19:57 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (37.25 KB, patch)
2020-07-16 20:16 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (37.19 KB, patch)
2020-08-22 16:26 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-07-16 08:19:25 PDT 
This is a preparation for multiple line boxes on the line.
Comment 1 zalan 2020-07-16 08:57:41 PDT 
Created attachment 404442 [details]
Patch
Comment 2 zalan 2020-07-16 19:37:19 PDT 
Created attachment 404519 [details]
Patch
Comment 3 zalan 2020-07-16 19:57:04 PDT 
Created attachment 404522 [details]
Patch
Comment 4 zalan 2020-07-16 20:16:49 PDT 
Created attachment 404527 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2020-07-23 08:20:16 PDT 
<rdar://problem/65992768>
Comment 6 Antti Koivisto 2020-08-22 10:42:38 PDT 
Comment on attachment 404527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404527&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.h:227
> +    InlineBox m_lineBox;

Maybe the names should match?
Comment 7 zalan 2020-08-22 16:26:26 PDT 
Created attachment 407059 [details]
Patch
Comment 8 EWS 2020-08-22 18:15:06 PDT 
Committed r266040: <https://trac.webkit.org/changeset/266040>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407059 [details].
Comment 9 zalan 2020-08-22 19:46:09 PDT 
(In reply to Antti Koivisto from comment #6)
> Comment on attachment 404527 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404527&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBuilder.h:227
> > +    InlineBox m_lineBox;
> 
> Maybe the names should match?
Maybe they should!