Bug 214401 – Fix ITP data summary when using the memory store and blocking all third-party cookies

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

The memory store behaves differently than the database one, it only includes prevalent resources in the list, while the database store includes all resources when cooking blocking policy is All.

[Carlos Garcia Campos]

Created attachment 404432 [details]
Patch

[Michael Catanzaro]

Comment on attachment 404432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404432&action=review

I'm pretty sure this change is correct.

Let's give John a day or two to do the final review, though, since it's his code.

> Source/WebKit/ChangeLog:3
> +        Fix ITP data summary when using the memory satre and blocking all third-party cookies

memory store

[Kate Cheney]

Great catch! I am the engineer who added the ITP data summary, this change looks good. It would be nice to also update the ITP data summary test case in this patch before landing, looks like it is missing the piece of code which turns off database mode.

You can turn it off by adding:

 static bool doneFlag = false;
    [dataStore _setUseITPDatabase:false completionHandler: ^(void) {
        doneFlag = true;
    }];

    TestWebKitAPI::Util::run(&doneFlag);

right after calling 

[dataStore _setResourceLoadStatisticsEnabled:YES] 

in the GetResourceLoadStatisticsDataSummary test in TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm. The test should fail before your change, and pass after.

[Carlos Garcia Campos]

Created attachment 404805 [details]
Patch for landing

[Carlos Garcia Campos]

Committed r264650: <https://trac.webkit.org/changeset/264650>

[Radar WebKit Bug Importer]

<rdar://problem/65878342>