Bug 214400 - Double tapping to zoom out a fullscreen video will zoom in slightly before zooming out
Summary: Double tapping to zoom out a fullscreen video will zoom in slightly before zo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-15 23:26 PDT by Peng Liu
Modified: 2020-07-16 10:59 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.91 KB, patch)
2020-07-15 23:53 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
A better patch (6.08 KB, patch)
2020-07-16 10:23 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-07-15 23:26:01 PDT 
Double tapping to zoom out a fullscreen video will zoom in slightly before zooming out
Comment 1 Peng Liu 2020-07-15 23:26:47 PDT 
<rdar://problem/64579374>
Comment 2 Peng Liu 2020-07-15 23:53:10 PDT 
Created attachment 404426 [details]
Patch
Comment 3 Peng Liu 2020-07-16 10:04:19 PDT 
Comment on attachment 404426 [details]
Patch

This patch handles two video gravity changes differently:
1) AVLayerVideoGravityResizeAspect -> AVLayerVideoGravityResizeAspectFill,
2) AVLayerVideoGravityResizeAspectFill -> AVLayerVideoGravityResizeAspect).

The animation happens on the UI process for 1), and the animation happens on the web process for 2). We had better let the animations happen on the UI process for both cases.
Comment 4 Peng Liu 2020-07-16 10:23:36 PDT 
Created attachment 404461 [details]
A better patch
Comment 5 EWS 2020-07-16 10:59:27 PDT 
Committed r264471: <https://trac.webkit.org/changeset/264471>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404461 [details].