Bug 214380 – [WebAuthn] Add a console message: "User gesture is required to use the platform authenticator."

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jiewen Tan]

Add a console message: "User gesture is required to use the platform authenticator." when the user gesture is not presented.

[Jiewen Tan]

<rdar://problem/65300587>

[Jiewen Tan]

Created attachment 404400 [details]
Patch

[Jiewen Tan]

Created attachment 404407 [details]
Patch

[Jiewen Tan]

Created attachment 404470 [details]
Patch

[Devin Rousso]

Comment on attachment 404470 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404470&action=review

r=me

> Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:57
> +        m_webPage.addConsoleMessage(webFrame->frameID(), MessageSource::Other, MessageLevel::Warning, "User gesture is required to use the platform authenticator."_s);

Is there any way we can make this message more descriptive?  There's barely anything actionable here for a developer to use.  The fact that every log is the exact same in the LayoutTests is indicative of the problem :(

Also, can you add `#include <JavaScriptCore/ConsoleTypes.h>`?

[Jiewen Tan]

Comment on attachment 404470 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404470&action=review

Thanks Devin for r+ this patch.

>> Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:57
>> +        m_webPage.addConsoleMessage(webFrame->frameID(), MessageSource::Other, MessageLevel::Warning, "User gesture is required to use the platform authenticator."_s);
> 
> Is there any way we can make this message more descriptive?  There's barely anything actionable here for a developer to use.  The fact that every log is the exact same in the LayoutTests is indicative of the problem :(
> 
> Also, can you add `#include <JavaScriptCore/ConsoleTypes.h>`?

Fixed the sentence and the header. Unfortunately, the web process doesn't have the necessary information to make a more fine grained message. Since this is a warning and for people that need it, it should be very clear for them. Therefore, the granularity here should be sufficient.

[Jiewen Tan]

Created attachment 404501 [details]
Patch for landing

[EWS]

Committed r264490: <https://trac.webkit.org/changeset/264490>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404501 [details].