Bug 214369 - [run-javascriptcore-tests] nativeArchitecture should never be arm64e
Summary: [run-javascriptcore-tests] nativeArchitecture should never be arm64e
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 13
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-15 12:07 PDT by Jonathan Bedard
Modified: 2020-07-15 14:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2020-07-15 12:12 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-07-15 12:07:13 PDT
For internal builds, architecture should be arm64e by default, but native architecture should be arm64.
Comment 1 Jonathan Bedard 2020-07-15 12:08:38 PDT
<rdar://problem/65364995>
Comment 2 Jonathan Bedard 2020-07-15 12:12:54 PDT
Created attachment 404371 [details]
Patch
Comment 3 EWS 2020-07-15 13:03:22 PDT
Committed r264416: <https://trac.webkit.org/changeset/264416>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404371 [details].
Comment 4 Saam Barati 2020-07-15 13:05:50 PDT
(In reply to Jonathan Bedard from comment #0)
> For internal builds, architecture should be arm64e by default, but native
> architecture should be arm64.

What’s the distinction for? These function names make it difficult to see what it’s used for and why your fix is needed.
Comment 5 Tim Horton 2020-07-15 13:07:00 PDT
(Agreed, I think we need better names or comments about why this is so wacky)
Comment 6 Jonathan Bedard 2020-07-15 14:00:21 PDT
(In reply to Saam Barati from comment #4)
> (In reply to Jonathan Bedard from comment #0)
> > For internal builds, architecture should be arm64e by default, but native
> > architecture should be arm64.
> 
> What’s the distinction for? These function names make it difficult to see
> what it’s used for and why your fix is needed.

'architecture' means 'the architecture the user intends to build or test with' while 'native architecture' means 'the architecture that a machine will use to run code'

Renaming probably isn't practical (since architecture is used in code not checked into WebKit), so comments are probably the way to go.