Bug 214369 – [run-javascriptcore-tests] nativeArchitecture should never be arm64e

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

For internal builds, architecture should be arm64e by default, but native architecture should be arm64.

[Jonathan Bedard]

<rdar://problem/65364995>

[Jonathan Bedard]

Created attachment 404371 [details]
Patch

[EWS]

Committed r264416: <https://trac.webkit.org/changeset/264416>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404371 [details].

[Saam Barati]

(In reply to Jonathan Bedard from comment #0)
> For internal builds, architecture should be arm64e by default, but native
> architecture should be arm64.

What’s the distinction for? These function names make it difficult to see what it’s used for and why your fix is needed.

[Tim Horton]

(Agreed, I think we need better names or comments about why this is so wacky)

[Jonathan Bedard]

(In reply to Saam Barati from comment #4)
> (In reply to Jonathan Bedard from comment #0)
> > For internal builds, architecture should be arm64e by default, but native
> > architecture should be arm64.
> 
> What’s the distinction for? These function names make it difficult to see
> what it’s used for and why your fix is needed.

'architecture' means 'the architecture the user intends to build or test with' while 'native architecture' means 'the architecture that a machine will use to run code'

Renaming probably isn't practical (since architecture is used in code not checked into WebKit), so comments are probably the way to go.