Bug 214365 - Improve handling of invalid ChangeLog by webkit-patch
Summary: Improve handling of invalid ChangeLog by webkit-patch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-15 11:23 PDT by Simon Fraser (smfr)
Modified: 2020-07-16 09:07 PDT (History)
7 users (show)

See Also:


Attachments
My cached changes (18.96 KB, patch)
2020-07-15 11:23 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (1.60 KB, patch)
2020-07-16 08:08 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-07-15 11:23:07 PDT
OpenSource % wkpatch upload -g HEAD.... --no-review --no-obsolete
Total errors found: 0 in 13 files
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 80, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 75, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 106, in run
    self._ensure_bug_url(state)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 58, in _ensure_bug_url
    if not changelog.latest_entry().bug_id():
AttributeError: 'NoneType' object has no attribute 'bug_id'

Will attach my local diff.
Comment 1 Simon Fraser (smfr) 2020-07-15 11:23:42 PDT
Created attachment 404360 [details]
My cached changes
Comment 2 Simon Fraser (smfr) 2020-07-15 13:00:20 PDT
The WebKit/Changelog file has a space at the start of the date line.
Comment 3 Aakash Jain 2020-07-16 08:08:01 PDT
Created attachment 404441 [details]
Patch
Comment 4 EWS 2020-07-16 09:06:08 PDT
Committed r264455: <https://trac.webkit.org/changeset/264455>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404441 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-16 09:07:57 PDT
<rdar://problem/65669064>