Bug 214365 – Improve handling of invalid ChangeLog by webkit-patch

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Simon Fraser (smfr)]

OpenSource % wkpatch upload -g HEAD.... --no-review --no-obsolete
Total errors found: 0 in 13 files
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 80, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 75, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 106, in run
    self._ensure_bug_url(state)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 58, in _ensure_bug_url
    if not changelog.latest_entry().bug_id():
AttributeError: 'NoneType' object has no attribute 'bug_id'

Will attach my local diff.

[Simon Fraser (smfr)]

Created attachment 404360 [details]
My cached changes

[Simon Fraser (smfr)]

The WebKit/Changelog file has a space at the start of the date line.

[Aakash Jain]

Created attachment 404441 [details]
Patch

[EWS]

Committed r264455: <https://trac.webkit.org/changeset/264455>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404441 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65669064>