Bug 214362 - itsnicethat.com page is sometimes non-scrollable
Summary: itsnicethat.com page is sometimes non-scrollable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-15 11:01 PDT by Simon Fraser (smfr)
Modified: 2020-07-15 19:15 PDT (History)
11 users (show)

See Also:

Attachments
Patch (19.83 KB, patch)
2020-07-15 11:07 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Patch for EWS (18.96 KB, patch)
2020-07-15 11:24 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-07-15 11:01:08 PDT 
itsnicethat.com page is sometimes non-scrollable
Comment 1 Simon Fraser (smfr) 2020-07-15 11:07:30 PDT 
Created attachment 404359 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-07-15 11:07:33 PDT 
<rdar://problem/65431127>
Comment 3 Tim Horton 2020-07-15 11:11:42 PDT 
Comment on attachment 404359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404359&action=review

> Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm:113
> +    if ([self.mask isKindOfClass:[CAShapeLayer class]]) {
> +        CAShapeLayer *shapeMask = static_cast<CAShapeLayer *>(self.mask);

I think you can merge these two lines with a dynamic_objc_cast (same above)
Comment 4 Simon Fraser (smfr) 2020-07-15 11:24:12 PDT 
Created attachment 404361 [details]
Patch for EWS
Comment 5 EWS 2020-07-15 12:55:13 PDT 
Invalid ChangeLog at /Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog
Comment 6 Simon Fraser (smfr) 2020-07-15 13:02:53 PDT 
https://trac.webkit.org/changeset/264415/webkit