Bug 214355 - [ews-app] Add timeout to network requests
Summary: [ews-app] Add timeout to network requests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2020-07-15 08:24 PDT by Aakash Jain
Modified: 2020-11-16 11:36 PST (History)
4 users (show)

See Also:

Patch (1.58 KB, patch)
2020-07-15 08:27 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-07-15 08:24:05 PDT
Sometimes network requests can get stuck or take very long time. on ews-app it can introduce delays in patch submissions from EWS django app to Buildbot. We should add an explicit timeout to network requests, so that the network request is timely terminated and retried in subsequent iteration of ews-app appropriately.
Comment 1 Aakash Jain 2020-07-15 08:27:48 PDT
Created attachment 404343 [details]
Comment 2 Aakash Jain 2020-07-15 08:28:56 PDT
As per https://requests.readthedocs.io/en/master/user/quickstart/#timeouts:
"Nearly all production code should use this parameter in nearly all requests. Failure to do so can cause your program to hang indefinitely"
Comment 3 Aakash Jain 2020-07-15 08:39:44 PDT
In the past, I noticed few times ews-app getting stuck and not submitting patches to Buildbot for long time (even though the status-bubbles and /results kept working fine), restarting ews-app helped at those times. I believe I finally got to the bottom of the issue.
Comment 4 EWS 2020-07-15 09:24:27 PDT
Committed r264399: <https://trac.webkit.org/changeset/264399>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404343 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-15 09:25:13 PDT