Bug 214349 – [MSE][GStreamer] imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html is flaky fail/crash

• Status: REOPENED
• Component: WebKitGTK

[Alicia Boya García]

New test imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html crashes on an assertion.

This is not surprising since changetype is not implemented in our port and we already had a similar crash with that feature. Marking it as [ Failure Crash ].

[Alicia Boya García]

Created attachment 404336 [details]
Patch for landing

[EWS]

Committed r264393: <https://trac.webkit.org/changeset/264393>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404336 [details].

[Philippe Normand]

This was unflagged by mistake, it's been consistently hitting this ASSERT on the GTK Debug bot, at least:

ASSERTION FAILED: stream->type == Video
../../Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp(241) : void WebCore::PlaybackPipeline::reattachTrack(RefPtr<WebCore::SourceBufferPrivateGStreamer>, RefPtr<WebCore::TrackPrivateBase>, GstCaps *)
1   0x7f992ea5fc79 WTFCrash
2   0x7f993b672e4b /app/webkit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb4b8e4b) [0x7f993b672e4b]
3   0x7f9940b0ce33 WebCore::PlaybackPipeline::reattachTrack(WTF::RefPtr<WebCore::SourceBufferPrivateGStreamer, WTF::RawPtrTraits<WebCore::SourceBufferPrivateGStreamer>, WTF::DefaultRefDerefTraits<WebCore::SourceBufferPrivateGStreamer> >, WTF::RefPtr<WebCore::TrackPrivateBase, WTF::RawPtrTraits<WebCore::TrackPrivateBase>, WTF::DefaultRefDerefTraits<WebCore::TrackPrivateBase> >, _GstCaps*)
4   0x7f9940b01b11 WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected(WebCore::AppendPipeline&, WTF::RefPtr<WebCore::TrackPrivateBase, WTF::RawPtrTraits<WebCore::TrackPrivateBase>, WTF::DefaultRefDerefTraits<WebCore::TrackPrivateBase> >, bool)
5   0x7f9940ff074a WebCore::AppendPipeline::appsinkCapsChanged()
6   0x7f9940ff3eb8 /app/webkit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x10e39eb8) [0x7f9940ff3eb8]
7   0x7f9940ff3e8e /app/webkit/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x10e39e8e) [0x7f9940ff3e8e]
8   0x7f9940ffc812 WTF::Function<WebCore::AbortableTaskQueue::Void ()>::operator()() const
9   0x7f9940ffc724 WebCore::AbortableTaskQueue::enqueueTaskAndWait<WebCore::AbortableTaskQueue::Void>(WTF::Function<WebCore::AbortableTaskQueue::Void ()>&&)::{lambda()#1}::operator()() const
10  0x7f9940ffc6ee WTF::Detail::CallableWrapper<WebCore::AbortableTaskQueue::enqueueTaskAndWait<WebCore::AbortableTaskQueue::Void>(WTF::Function<WebCore::AbortableTaskQueue::Void ()>&&)::{lambda()#1}, void>::call()
11  0x7f993b672612 WTF::Function<void ()>::operator()() const
12  0x7f9940ffaf60 WebCore::AbortableTaskQueue::Task::dispatch()
13  0x7f9940ffadfd WebCore::AbortableTaskQueue::postTask(WTF::Function<void ()>&&)::{lambda()#1}::operator()() const
14  0x7f9940ffadce WTF::Detail::CallableWrapper<WebCore::AbortableTaskQueue::postTask(WTF::Function<void ()>&&)::{lambda()#1}, void>::call()
15  0x7f993b672612 WTF::Function<void ()>::operator()() const
16  0x7f992ea98875 WTF::RunLoop::performWork()
17  0x7f992eb3236c /app/webkit/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x3f6536c) [0x7f992eb3236c]
18  0x7f992eb32345 /app/webkit/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x3f65345) [0x7f992eb32345]
19  0x7f992eb322f9 /app/webkit/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x3f652f9) [0x7f992eb322f9]
20  0x7f992eb31375 /app/webkit/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x3f64375) [0x7f992eb31375]
21  0x7f9927a8d18f g_main_context_dispatch
22  0x7f9927a8d538 /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x56538) [0x7f9927a8d538]
23  0x7f9927a8d853 g_main_loop_run
24  0x7f992eb319a8 WTF::RunLoop::run()
25  0x7f993cdbd308 int WebKit::AuxiliaryProcessMain<WebKit::WebProcess, WebKit::WebProcessMainGtk>(int, char**)
26  0x7f993cdbd01b WebKit::WebProcessMain(int, char**)
27  0x400c56 /app/webkit/WebKitBuild/Debug/bin/WebKitWebProcess() [0x400c56]
28  0x7f99265eb022 __libc_start_main
29  0x400b5e /app/webkit/WebKitBuild/Debug/bin/WebKitWebProcess() [0x400b5e]

[Carlos Alberto Lopez Perez]

On GTK release bot it also crashes sometimes

[Carlos Alberto Lopez Perez]

Updated expectations on r275423