Bug 214343 - [JSC] Introduce JSCTEST_hardTimeout
Summary: [JSC] Introduce JSCTEST_hardTimeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
: 210063 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-07-15 00:30 PDT by Yusuke Suzuki
Modified: 2020-07-15 23:25 PDT (History)
8 users (show)

See Also:


Attachments
Patch (7.76 KB, patch)
2020-07-15 00:38 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (7.75 KB, patch)
2020-07-15 00:50 PDT, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff
Patch for landing (7.74 KB, patch)
2020-07-15 01:32 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-07-15 00:30:15 PDT
[JSC] Introduce JSCTEST_hardTimeout
Comment 1 Yusuke Suzuki 2020-07-15 00:38:35 PDT
Created attachment 404324 [details]
Patch
Comment 2 Yusuke Suzuki 2020-07-15 00:50:05 PDT
Created attachment 404325 [details]
Patch
Comment 3 Mark Lam 2020-07-15 00:59:24 PDT
Comment on attachment 404325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404325&action=review

> Tools/Scripts/run-jsc-stress-tests:2242
> +# We do not adjust hardTimeout. If we are not producing any results during 1200 seconds, buildbot terminates the tests. So we should terminate stucking tests.

I suggest /stucking/hung/.
Comment 4 Yusuke Suzuki 2020-07-15 01:23:44 PDT
Comment on attachment 404325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404325&action=review

Thanks!

>> Tools/Scripts/run-jsc-stress-tests:2242
>> +# We do not adjust hardTimeout. If we are not producing any results during 1200 seconds, buildbot terminates the tests. So we should terminate stucking tests.
> 
> I suggest /stucking/hung/.

Fixed.
Comment 5 Yusuke Suzuki 2020-07-15 01:32:42 PDT
Created attachment 404326 [details]
Patch for landing
Comment 6 Yusuke Suzuki 2020-07-15 02:53:47 PDT
the first patch's jsc EWS pass.
Comment 7 EWS 2020-07-15 03:18:44 PDT
Committed r264391: <https://trac.webkit.org/changeset/264391>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404326 [details].
Comment 8 Radar WebKit Bug Importer 2020-07-15 03:19:33 PDT
<rdar://problem/65595769>
Comment 9 Mark Lam 2020-07-15 23:25:18 PDT
*** Bug 210063 has been marked as a duplicate of this bug. ***