RESOLVED FIXED 214332
We must hold the CodeBlock lock when calling StructureStubInfo::reset 
https://bugs.webkit.org/show_bug.cgi?id=214332
Summary We must hold the CodeBlock lock when calling StructureStubInfo::reset
Saam Barati
Reported 2020-07-14 16:44:51 PDT
...
Attachments
patch (15.35 KB, patch)
2020-07-14 16:54 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-07-14 16:45:32 PDT
<rdar://problem/64940787>
Saam Barati
Comment 2 2020-07-14 16:54:18 PDT
Created attachment 404307 [details] patch
Yusuke Suzuki
Comment 3 2020-07-14 16:56:35 PDT
Comment on attachment 404307 [details] patch r=me
Saam Barati
Comment 4 2020-07-14 16:57:28 PDT
Comment on attachment 404307 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=404307&action=review > Source/JavaScriptCore/jit/Repatch.cpp:148 > + { > + GCSafeConcurrentJSLocker locker(codeBlock->m_lock, vm.heap); > + stubInfo.reset(locker, codeBlock); > + } this is the bug fix
EWS
Comment 5 2020-07-14 22:54:50 PDT
Committed r264388: <https://trac.webkit.org/changeset/264388> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404307 [details].
Note You need to log in before you can comment on or make changes to this bug.