Bug 21433 - Auto-generate the DOMDocument createNodeIterator: and createTreeWalker: methods
Summary: Auto-generate the DOMDocument createNodeIterator: and createTreeWalker: methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-07 10:24 PDT by Timothy Hatcher
Modified: 2008-10-07 14:50 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (29.29 KB, patch)
2008-10-07 10:50 PDT, Timothy Hatcher 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2008-10-07 10:24:19 PDT 
We should auto-generate these methods.
Comment 1 Timothy Hatcher 2008-10-07 10:50:55 PDT 
Created attachment 24152 [details]
Proposed patch
Comment 2 Sam Weinig 2008-10-07 14:00:22 PDT 
Comment on attachment 24152 [details]
Proposed patch

+        RetainPtr<id <DOMNodeFilter> > m_filter;
+    };
+
+} // namespace WebCore
+
+#endif

The #endif should have a comment. 

+#import "config.h"
+
+#include "ObjCNodeFilterCondition.h"
+
+#include "DOMNodeFilter.h"
+#include "DOMNodeInternal.h"
+#include "NodeFilter.h"
Shouldn't these all be #imports.

r=me
Comment 3 Timothy Hatcher 2008-10-07 14:50:09 PDT 
Landed in r37396.