webanimations/accelerated-animation-with-easing.html It looks like after the changes in https://trac.webkit.org/changeset/263761/webkit is still flaky History: https://results.webkit.org/?suite=layout-tests&test=webanimations%2Faccelerated-animation-with-easing.html Diff: https://build.webkit.org/results/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20(Tests)/r264368%20(4689)/webanimations/accelerated-animation-with-easing-diffs.html
<rdar://problem/65569237>
Created attachment 404297 [details] Patch
Comment on attachment 404297 [details] Patch Clearing flags on attachment: 404297 Committed r264378: <https://trac.webkit.org/changeset/264378>
This test was landed flaky, fix attempted in r263761, but it's still flaky. Difference is a vertical red line.
Created attachment 405561 [details] Patch
Comment on attachment 405561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405561&action=review > Source/WebKit/ChangeLog:18 > + This fixes the test added originally in r263506 which would only work flakily, a sympton of this Typo: symptom. > Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:156 > +static void encodeTimingFunction(IPC::Encoder& encoder, TimingFunction* timingFunction) I think these methods should go in WebCoreArgumentCoders. > Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:239 > + encodeTimingFunction(encoder, timingFunction.get()); Which would just make this encoder << timingFunction.get();
Committed r265098: <https://trac.webkit.org/changeset/265098>
Comment on attachment 405561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405561&action=review >> Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:156 >> +static void encodeTimingFunction(IPC::Encoder& encoder, TimingFunction* timingFunction) > > I think these methods should go in WebCoreArgumentCoders. This should take a const TimingFunction&