Bug 214326 – Selection is not always clearing when tapping.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Selection is not always clearing when tapping.

[Megan Gardner]

<rdar://problem/65069201>

[Megan Gardner]

Created attachment 404305 [details]
Patch

[Wenson Hsieh]

Comment on attachment 404305 [details]
Patch

Can we remove the `!_page->editorState().selectionIsRange` check too?

This is also something we should be able to write a test for.

[Megan Gardner]

We can, but I figured it was a reasonable short-circuit, so I didn't take it out.

[Wenson Hsieh]

(In reply to Megan Gardner from comment #4)
> We can, but I figured it was a reasonable short-circuit, so I didn't take it
> out.

👍🏻 Sounds reasonable

[Megan Gardner]

Created attachment 404476 [details]
Patch

[Wenson Hsieh]

Comment on attachment 404476 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404476&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2574
>                  if (!_page->editorState().selectionIsRange)
>                      return NO;
> -                return [self _pointIsInsideSelectionRect:point outBoundingRect:nil];
> +                return YES;

Nit - this might be cleaner as just `return _page->editorState().selectionIsRange;`

> LayoutTests/editing/selection/ios/hide-selection-after-tap-on-prevent-default-element.html:53
> +    //await UIHelper.delayFor(1000);

Nit - stray commented out code.

[Megan Gardner]

Created attachment 404484 [details]
Patch for landing

[EWS]

Committed r264481: <https://trac.webkit.org/changeset/264481>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404484 [details].