Bug 214325 - Emit HasOwnPropertyFunctionCallDotNode for "Reflect" identifiers
Summary: Emit HasOwnPropertyFunctionCallDotNode for "Reflect" identifiers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-14 14:58 PDT by Alexey Shvayka
Modified: 2020-07-15 07:48 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.13 KB, patch)
2020-07-14 15:01 PDT, Alexey Shvayka
no flags Details | Formatted Diff | Diff
Patch (4.16 KB, patch)
2020-07-15 00:36 PDT, Alexey Shvayka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2020-07-14 14:58:45 PDT
Emit HasOwnPropertyFunctionCallDotNode for "Reflect" identifiers
Comment 1 Alexey Shvayka 2020-07-14 15:01:48 PDT
Created attachment 404290 [details]
Patch
Comment 2 Alexey Shvayka 2020-07-14 15:02:23 PDT
(In reply to Alexey Shvayka from comment #1)
> Created attachment 404290 [details]
> Patch

Warmed-up runs, --outer 50:

                                                        r264266                    patch                                       

has-own-property-for-in-loop-with-heap-variable     35.9192+-2.6893     ^     29.2597+-0.7042        ^ definitely 1.2276x faster
Comment 3 Mark Lam 2020-07-14 15:49:05 PDT
Comment on attachment 404290 [details]
Patch

Let's hold off on committing this until after the EWS bots finish testing.  Thanks.
Comment 4 Saam Barati 2020-07-14 16:56:56 PDT
Comment on attachment 404290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404290&action=review

Good call. I think I was mistakenly thinking of "Reflect.has" when I wrote the code.

r=me too

> JSTests/microbenchmarks/has-own-property-for-in-loop-with-heap-variable.js:-7
> -    let o = {

let's add a new test.
Comment 5 Mark Lam 2020-07-14 17:14:49 PDT
Comment on attachment 404290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404290&action=review

>> JSTests/microbenchmarks/has-own-property-for-in-loop-with-heap-variable.js:-7
>> -    let o = {
> 
> let's add a new test.

By "let's add a new test", I think Saam meant, let's not modify this one, but add a clone of this one that uses Reflect instead.
Comment 6 Mark Lam 2020-07-14 17:17:25 PDT
Comment on attachment 404290 [details]
Patch

Removing the cq? because the test needs to be updated.  I would still like to see the EWS tests run to completion on this patch (since they are almost there already).
Comment 7 Alexey Shvayka 2020-07-15 00:36:13 PDT
Created attachment 404323 [details]
Patch

Clone test instead of modifying.
Comment 8 EWS 2020-07-15 07:47:48 PDT
Committed r264397: <https://trac.webkit.org/changeset/264397>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404323 [details].
Comment 9 Radar WebKit Bug Importer 2020-07-15 07:48:15 PDT
<rdar://problem/65605240>