Bug 214325 – Emit HasOwnPropertyFunctionCallDotNode for "Reflect" identifiers

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Alexey Shvayka]

Emit HasOwnPropertyFunctionCallDotNode for "Reflect" identifiers

[Alexey Shvayka]

Created attachment 404290 [details]
Patch

[Alexey Shvayka]

(In reply to Alexey Shvayka from comment #1)
> Created attachment 404290 [details]
> Patch

Warmed-up runs, --outer 50:

                                                        r264266                    patch                                       

has-own-property-for-in-loop-with-heap-variable     35.9192+-2.6893     ^     29.2597+-0.7042        ^ definitely 1.2276x faster

[Mark Lam]

Comment on attachment 404290 [details]
Patch

Let's hold off on committing this until after the EWS bots finish testing.  Thanks.

[Saam Barati]

Comment on attachment 404290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404290&action=review

Good call. I think I was mistakenly thinking of "Reflect.has" when I wrote the code.

r=me too

> JSTests/microbenchmarks/has-own-property-for-in-loop-with-heap-variable.js:-7
> -    let o = {

let's add a new test.

[Mark Lam]

Comment on attachment 404290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404290&action=review

>> JSTests/microbenchmarks/has-own-property-for-in-loop-with-heap-variable.js:-7
>> -    let o = {
> 
> let's add a new test.

By "let's add a new test", I think Saam meant, let's not modify this one, but add a clone of this one that uses Reflect instead.

[Mark Lam]

Comment on attachment 404290 [details]
Patch

Removing the cq? because the test needs to be updated.  I would still like to see the EWS tests run to completion on this patch (since they are almost there already).

[Alexey Shvayka]

Created attachment 404323 [details]
Patch

Clone test instead of modifying.

[EWS]

Committed r264397: <https://trac.webkit.org/changeset/264397>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404323 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65605240>