WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
21432
Auto-generate the DOMEventTarget protocol implementation for DOMNode and DOMSVGElementInstance
https://bugs.webkit.org/show_bug.cgi?id=21432
Summary
Auto-generate the DOMEventTarget protocol implementation for DOMNode and DOMS...
Timothy Hatcher
Reported
2008-10-07 10:21:31 PDT
We should auto-generate these protocol implementations.
Attachments
Proposed patch
(30.38 KB, patch)
2008-10-07 10:21 PDT
,
Timothy Hatcher
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Timothy Hatcher
Comment 1
2008-10-07 10:21:59 PDT
Created
attachment 24149
[details]
Proposed patch
Darin Adler
Comment 2
2008-10-07 10:30:58 PDT
Comment on
attachment 24149
[details]
Proposed patch + #if defined(LANGUAGE_OBJECTIVE_C) + : Object, EventTarget + #endif /* defined(LANGUAGE_OBJECTIVE_C) */ What's "Object" here and why is it needed? Why does this need to be ObjC-specific?
Timothy Hatcher
Comment 3
2008-10-07 10:50:21 PDT
(In reply to
comment #2
)
> (From update of
attachment 24149
[details]
[edit]) > + #if defined(LANGUAGE_OBJECTIVE_C) > + : Object, EventTarget > + #endif /* defined(LANGUAGE_OBJECTIVE_C) */ > > What's "Object" here and why is it needed? Why does this need to be > ObjC-specific? >
Object will turn into DOMObject. This is needed to take the code generator down the right path of multiple super-classes as protocols. It is ObjC only for legacy reasons. The event target methods are normally on NodeEventTarget, a subclass of Node. But the ObjC API has never has this sub-class and they are on DOMNode. I will add this info to the ChangeLog.
Timothy Hatcher
Comment 4
2008-10-07 14:49:55 PDT
Landed in
r37395
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug