Bug 214309 – [webkitcorepy] Spin off general webkitpy tools into a pip module

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

This bug is intended as the start of a discussion on how to better organize our Python tooling so that it's 1) more re-usable (particularly relevant for services) 2) better tested 3) less coupled to WebKit's specific development quirks.

Eventually, the intention is to break off many more parts of webkitpy into this, or other, modules until webkitpy only contains code specific to developing WebKit within the WebKit checkout.

[Jonathan Bedard]

Created attachment 404258 [details]
Patch

[Jonathan Bedard]

Comment on attachment 404258 [details]
Patch

The consensus I've heard so far is that this is the right direction.

Obviously a single class is insufficient for a library, but I think that doing this piece-by-piece will result in cleaner SCM history as well as more thorough code review.

Comment on attachment 404258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404258&action=review

> Tools/Scripts/webkitpy/port/win.py:-40
> -from webkitpy.common.system.executive import Executive

Do we intentionally remove this? If so, maybe we should mention it in the change log.

[Jonathan Bedard]

Comment on attachment 404258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404258&action=review

>> Tools/Scripts/webkitpy/port/win.py:-40
>> -from webkitpy.common.system.executive import Executive
> 
> Do we intentionally remove this? If so, maybe we should mention it in the change log.

This was intentional, I have an IDE configured and removed unused imports. I'll update changelogs.

Comment on attachment 404258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404258&action=review

>>> Tools/Scripts/webkitpy/port/win.py:-40
>>> -from webkitpy.common.system.executive import Executive
>> 
>> Do we intentionally remove this? If so, maybe we should mention it in the change log.
> 
> This was intentional, I have an IDE configured and removed unused imports. I'll update changelogs.

Got it.

[Fujii Hironori]

pip? Do you plan to add the such modules into PyPI? And, use them by auto-installing?

[Jonathan Bedard]

(In reply to Fujii Hironori from comment #6)
> pip? Do you plan to add the such modules into PyPI? And, use them by
> auto-installing?

We definitely are going to be adding these to a package index, not clear yet if we want to add them to the globally accessible one. (Apple has a private package index which we prefer over the global one, but other organizations developing WebKit may want to install these packages, which would likely push us to add them to the global package index)

As for auto-installing, yes, but not for WebKit development from the WebKit repository. That should remain unchanged because it's useful to pair WebKit changes with script changes. The use case for auto-installing our own packages that I had in mind is the various Python services we host (which don't share a ton of code at the moment)

[Jonathan Bedard]

Created attachment 404392 [details]
Patch for landing

[EWS]

Committed r264425: <https://trac.webkit.org/changeset/264425>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404392 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65627721>