Bug 214304 – [iOS] Avoid loading media libraries in Document::visibilityStateChanged() if not needed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

When the shared PlatformMediaSessionManager is created and accessed for the first time, some media libraries are loaded. There should be no need to access the shared PlatformMediaSessionManager if no manager has been created in Document::visibilityStateChanged().

[Per Arne Vollan]

rdar://problem/65005038

[Per Arne Vollan]

Created attachment 404245 [details]
Patch

[Per Arne Vollan]

Comment on attachment 404245 [details]
Patch

Thanks for reviewing!

[EWS]

Committed r264359: <https://trac.webkit.org/changeset/264359>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404245 [details].

[Simon Fraser (smfr)]

Comment on attachment 404245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404245&action=review

> Source/WebCore/dom/Document.cpp:1761
> +    if (PlatformMediaSessionManager::sharedManagerIfExists()) {
> +        if (!PlatformMediaSessionManager::sharedManager().isInterrupted())
> +            MediaStreamTrack::updateCaptureAccordingToMutedState(*this);
> +    }

if (auto mediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists())
  if (mediaSessionManager->isInterrupted())
....

[Per Arne Vollan]

(In reply to Simon Fraser (smfr) from comment #5)
> Comment on attachment 404245 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404245&action=review
> 
> > Source/WebCore/dom/Document.cpp:1761
> > +    if (PlatformMediaSessionManager::sharedManagerIfExists()) {
> > +        if (!PlatformMediaSessionManager::sharedManager().isInterrupted())
> > +            MediaStreamTrack::updateCaptureAccordingToMutedState(*this);
> > +    }
> 
> if (auto mediaSessionManager =
> PlatformMediaSessionManager::sharedManagerIfExists())
>   if (mediaSessionManager->isInterrupted())
> ....

Yes, that is better, I will a new patch :)

Thanks for reviewing!

[Per Arne Vollan]

Reopening to attach new patch.

[Per Arne Vollan]

Created attachment 404263 [details]
Patch

[EWS]

Committed r264370: <https://trac.webkit.org/changeset/264370>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404263 [details].