Bug 214288 - [macOS] Do not update ScreenTime when in private browsing mode
Summary: [macOS] Do not update ScreenTime when in private browsing mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-13 17:28 PDT by Eric Carlson
Modified: 2020-07-14 11:07 PDT (History)
11 users (show)

See Also:


Attachments
Patch (5.21 KB, patch)
2020-07-13 21:18 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch (7.25 KB, patch)
2020-07-14 09:32 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2020-07-13 17:28:09 PDT
Don't update ScreenTime when in private browsing mode
Comment 1 Eric Carlson 2020-07-13 17:28:51 PDT
<rdar://problem/63735067>
Comment 2 Eric Carlson 2020-07-13 21:18:10 PDT
Created attachment 404208 [details]
Patch
Comment 3 Alexey Proskuryakov 2020-07-14 07:29:23 PDT
Comment on attachment 404208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404208&action=review

> Source/WebCore/ChangeLog:3
> +        [macOS] Do not update ScreenTime when in private browsing mode

Why is this ok to do? This sounds like a complete bypass of private browsing restrictions.
Comment 4 Alexey Proskuryakov 2020-07-14 09:00:34 PDT
Comment on attachment 404208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404208&action=review

>> Source/WebCore/ChangeLog:3
>> +        [macOS] Do not update ScreenTime when in private browsing mode
> 
> Why is this ok to do? This sounds like a complete bypass of private browsing restrictions.

Sorry, I meant to say bypass of parental controls.
Comment 5 Alexey Proskuryakov 2020-07-14 09:04:18 PDT
I've been informed that private browsing can't be used under parental controls, so objection removed.
Comment 6 Eric Carlson 2020-07-14 09:32:13 PDT
Created attachment 404242 [details]
Patch
Comment 7 EWS 2020-07-14 11:07:28 PDT
Committed r264355: <https://trac.webkit.org/changeset/264355>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404242 [details].