Bug 214273 - Flashes of incorrect scroll position when zooming on quip
Summary: Flashes of incorrect scroll position when zooming on quip
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-13 14:28 PDT by Simon Fraser (smfr)
Modified: 2020-07-14 12:29 PDT (History)
3 users (show)

See Also:


Attachments
Patch (16.85 KB, patch)
2020-07-13 14:35 PDT, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff
Patch (16.85 KB, patch)
2020-07-13 14:50 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-07-13 14:28:42 PDT
Flashes of incorrect scroll position when zooming on quip
Comment 1 Simon Fraser (smfr) 2020-07-13 14:35:19 PDT
Created attachment 404175 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-07-13 14:35:22 PDT
<rdar://problem/59385421>
Comment 3 Tim Horton 2020-07-13 14:45:47 PDT
Comment on attachment 404175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404175&action=review

> Source/WebKit/ChangeLog:14
> +        When refusing such a scroll, we have to inform the web process to void mismatched ui/web process state,

is "void" "avoid" or something else?

> Source/WebKit/UIProcess/ios/WKContentView.mm:439
> +    sendEvenIfUnchanged:(BOOL)sendEvenIfUnchanged

We really gotta struct this up at some point
Comment 4 Simon Fraser (smfr) 2020-07-13 14:50:01 PDT
Created attachment 404178 [details]
Patch
Comment 5 Simon Fraser (smfr) 2020-07-14 12:29:21 PDT
https://trac.webkit.org/changeset/264368/webkit