Bug 214272 – [iOS] Sometimes unable to type Japanese on docs.google.com

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Daniel Bates]

Steps to reproduce:

1. Open Safari, tap URL bar and ensure English keyboard is being used.
2. Visit <https://docs.google.com> and create a new document.
3. Tap on URL bar and switch to Kana or Romaji.
4. Press Escape key on keyboard (Command + . if the keyboard doesn't have it)
5. Start typing.

Then Latin characters will be inserted. But Japanese characters should have been.

Note that bug may not occur again when repeating these steps in the **same** Safari session.

[Daniel Bates]

<rdar://problem/59449972>

[Daniel Bates]

Cannot write a test due to bug #199472 and fixing that requires some work to do....

[Daniel Bates]

Bug only happens, if it does, when key entry is via window/document event listeners. That is, there is no UCB on screen.

[Daniel Bates]

Created attachment 404183 [details]
Patch

[Darin Adler]

Comment on attachment 404183 [details]
Patch

No way to write a regression test?

[Daniel Bates]

(In reply to Darin Adler from comment #5)
> Comment on attachment 404183 [details]
> Patch
> 
> No way to write a regression test?

Of course there is, but the last I tried to do so I hit bug #199472 and to fix that is quite a bit of work and risk.

[Wenson Hsieh]

Comment on attachment 404183 [details]
Patch

I _could_ imagine writing an API test for this that directly invokes -handleKeyWebEvent:withCompletionHandler: inside _WKInputDelegate methods, and verifies that -handleKeyInputMethodCommandForCurrentEvent is consulted. It isn’t 100% ideal, but it is a way to exercise this change.

[Daniel Bates]

Thanks for the review Wenson!

[Daniel Bates]

Comment on attachment 404183 [details]
Patch

Clearing flags on attachment: 404183

Committed r264352: <https://trac.webkit.org/changeset/264352>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.