Bug 214263 - Crash under WebKit::LaunchServicesDatabaseManager::didConnect()
Summary: Crash under WebKit::LaunchServicesDatabaseManager::didConnect()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
: 214200 214227 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-07-13 10:30 PDT by Per Arne Vollan
Modified: 2020-07-13 12:42 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.94 KB, patch)
2020-07-13 10:33 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (1.73 KB, patch)
2020-07-13 10:36 PDT, Per Arne Vollan
darin: review+
Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2020-07-13 11:34 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-07-13 10:30:55 PDT
There is a crash under WebKit::LaunchServicesDatabaseManager::didConnect() when trying to send a message to an invalid connection.
Comment 1 Per Arne Vollan 2020-07-13 10:33:56 PDT
Created attachment 404154 [details]
Patch
Comment 2 Per Arne Vollan 2020-07-13 10:36:31 PDT
Created attachment 404155 [details]
Patch
Comment 3 Darin Adler 2020-07-13 10:52:21 PDT
Comment on attachment 404155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404155&action=review

> Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm:70
> +    auto conn = connection();

WebKit coding style says:

    auto connection = this->connection();
Comment 4 Per Arne Vollan 2020-07-13 11:34:08 PDT
Created attachment 404161 [details]
Patch
Comment 5 Per Arne Vollan 2020-07-13 11:34:43 PDT
(In reply to Darin Adler from comment #3)
> Comment on attachment 404155 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404155&action=review
> 
> > Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm:70
> > +    auto conn = connection();
> 
> WebKit coding style says:
> 
>     auto connection = this->connection();

Fixed.

Thanks for reviewing!
Comment 6 EWS 2020-07-13 12:13:09 PDT
Committed r264309: <https://trac.webkit.org/changeset/264309>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404161 [details].
Comment 7 Radar WebKit Bug Importer 2020-07-13 12:14:15 PDT
<rdar://problem/65492080>
Comment 8 Per Arne Vollan 2020-07-13 12:35:42 PDT
*** Bug 214200 has been marked as a duplicate of this bug. ***
Comment 9 Ryan Haddad 2020-07-13 12:42:11 PDT
*** Bug 214227 has been marked as a duplicate of this bug. ***