Bug 214254 - Skip intermittently failing type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value on mips
Summary: Skip intermittently failing type-check-hoisting-phase-hoist-check-structure-o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-13 06:36 PDT by Angelos Oikonomopoulos
Modified: 2020-07-14 04:27 PDT (History)
3 users (show)

See Also:

Attachments
Patch (700 bytes, patch)
2020-07-13 06:36 PDT, Angelos Oikonomopoulos 		no flags Details | Formatted Diff | Diff
Patch (700 bytes, patch)
2020-07-13 08:27 PDT, Angelos Oikonomopoulos 		no flags Details | Formatted Diff | Diff
Patch (725 bytes, patch)
2020-07-14 03:47 PDT, Angelos Oikonomopoulos 		no flags Details | Formatted Diff | Diff
Patch (1.36 KB, patch)
2020-07-14 03:48 PDT, Angelos Oikonomopoulos 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angelos Oikonomopoulos 2020-07-13 06:36:00 PDT 
Skip intermittently failing type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value on mips
Comment 1 Angelos Oikonomopoulos 2020-07-13 06:36:18 PDT 
Created attachment 404144 [details]
Patch
Comment 2 Angelos Oikonomopoulos 2020-07-13 08:27:02 PDT 
Created attachment 404149 [details]
Patch
Comment 3 Carlos Alberto Lopez Perez 2020-07-14 03:22:32 PDT 
Comment on attachment 404149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404149&action=review

> JSTests/stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js:1
> +//@ skip if (not $jitTests or ["mips"].include?($architecture))

nitpick: those extra parenthesis are not needed
Comment 4 EWS 2020-07-14 03:23:08 PDT 
Unable to find any modified ChangeLog in Attachment 404149 [details]
Comment 5 Carlos Alberto Lopez Perez 2020-07-14 03:25:17 PDT 
And you need to provide a changelog. Use the script prepare-changelog for that. Example of use:

Tools/Scripts/prepare-ChangeLog -b 214254 -g $localcommitgithashforthispatch
Comment 6 Angelos Oikonomopoulos 2020-07-14 03:47:16 PDT 
Created attachment 404220 [details]
Patch
Comment 7 Angelos Oikonomopoulos 2020-07-14 03:48:48 PDT 
Created attachment 404221 [details]
Patch
Comment 8 Angelos Oikonomopoulos 2020-07-14 03:51:18 PDT 
Oops, hopefully fixed now.
Comment 9 Carlos Alberto Lopez Perez 2020-07-14 04:02:25 PDT 
Comment on attachment 404221 [details]
Patch

thanks!
Comment 10 EWS 2020-07-14 04:26:35 PDT 
Committed r264336: <https://trac.webkit.org/changeset/264336>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404221 [details].
Comment 11 Radar WebKit Bug Importer 2020-07-14 04:27:14 PDT 
<rdar://problem/65533960>