Bug 214238 - Building CFNetworkSPI with the macOS Big Sur public SDK fails
Summary: Building CFNetworkSPI with the macOS Big Sur public SDK fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks: 214043
  Show dependency tree / graph
 
Reported: 2020-07-12 12:43 PDT by Rob Buis
Modified: 2020-07-12 23:29 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2020-07-12 12:48 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2020-07-12 14:41 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-07-12 12:43:34 PDT 
Build errors:
In file included from WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource198.cpp:5:
In file included from ./loader/CookieJar.cpp:35:
In file included from Source/WebCore/platform/network/NetworkStorageSession.h:42:
PAL/pal/spi/cf/CFNetworkSPI.h:71:1: error: expected unqualified-id
@interface _NSHTTPConnectionInfo : NSObject
^
PAL/pal/spi/cf/CFNetworkSPI.h:73:1: error: expected unqualified-id
@property (readonly) BOOL isValid;
^
PAL/pal/spi/cf/CFNetworkSPI.h:74:1: error: expected unqualified-id
@end
^
PAL/pal/spi/cf/CFNetworkSPI.h:78:1: error: expected unqualified-id
@end
^
Comment 1 Rob Buis 2020-07-12 12:48:07 PDT 
Created attachment 404113 [details]
Patch
Comment 2 Darin Adler 2020-07-12 14:29:27 PDT 
Comment on attachment 404113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404113&action=review

> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:72
>  #if HAVE(PRECONNECT_PING)
> +
> +#if defined(__OBJC__)

I’d slightly prefer this be && instead of two nested things.
Comment 3 Rob Buis 2020-07-12 14:41:37 PDT 
Created attachment 404117 [details]
Patch
Comment 4 EWS 2020-07-12 23:28:28 PDT 
Committed r264294: <https://trac.webkit.org/changeset/264294>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404117 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-12 23:29:14 PDT 
<rdar://problem/65457718>