Bug 214210 – Cleanup GameController framework button binding with some constants

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Cleanup GameController framework button binding with some constants

[Brady Eidson]

Created attachment 404022 [details]
Patch

[Darin Adler]

Comment on attachment 404022 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404022&action=review

> Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm:38
> +enum class GamepadButtons : uint8_t
> +{

WebKit coding style puts this on a single line.

[Brady Eidson]

(In reply to Darin Adler from comment #2)
> Comment on attachment 404022 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=404022&action=review
> 
> > Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm:38
> > +enum class GamepadButtons : uint8_t
> > +{
> 
> WebKit coding style puts this on a single line.

Yup, in my quick search I saw non-Webkit code's style and copied it. Whoops!

[Brady Eidson]

Failing to apply because it relied on https://bugs.webkit.org/show_bug.cgi?id=212933 landing

[Brady Eidson]

Created attachment 404027 [details]
Patch

[Darin Adler]

Comment on attachment 404027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404027&action=review

> Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm:101
> +    m_buttonValues.resize(homeButton ? (size_t)GamepadButtons::CenterClusterCenter + 1 : (size_t)GamepadButtons::CenterClusterCenter);

Not thrilled with how this hard-codes which is the last gamepad button 40 lines after the enum. Maybe two named constants right after the enum class would make the relationship clearer? Something like this perhaps:

    static constexpr auto numGamepadButtonsWithoutHomeButton = static_cast<size_t>(GamepadButtons::CenterClusterCenter) + 1;
    static constexpr auto numGamepadButtonsWithHomeButton = static_cast<size_t>(GamepadButtons::CenterClusterCenter);

[Brady Eidson]

Created attachment 404034 [details]
PFL

[EWS]

Committed r264258: <https://trac.webkit.org/changeset/264258>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404034 [details].

[Radar WebKit Bug Importer]

<rdar://problem/65380536>