Bug 214196 - Removing usage of "using namespace WebCore" from TextTrackRepresentationCocoa.mm
Summary: Removing usage of "using namespace WebCore" from TextTrackRepresentationCocoa.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: frankhome61
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-10 13:57 PDT by frankhome61
Modified: 2020-07-10 15:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.10 KB, patch)
2020-07-10 14:05 PDT, frankhome61 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description frankhome61 2020-07-10 13:57:56 PDT 
Removing the usage of using namespace WebCore from TextTrackRepresentationCocoa.mm, replace it with WebCore:: prefix, and use namespace WebCore { } block for C++ function implementations. 
This is to avoid potential namespace errors caused by unified source.
Comment 1 Radar WebKit Bug Importer 2020-07-10 13:58:35 PDT 
<rdar://problem/65362349>
Comment 2 frankhome61 2020-07-10 14:05:12 PDT 
Created attachment 403999 [details]
Patch
Comment 3 EWS 2020-07-10 14:58:00 PDT 
Committed r264241: <https://trac.webkit.org/changeset/264241>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403999 [details].
Comment 4 Simon Fraser (smfr) 2020-07-10 15:08:50 PDT 
Comment on attachment 403999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403999&action=review

> Source/WebCore/ChangeLog:13
> +        No new tests are requied as this is a code style fix

required