WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
214196
Removing usage of "using namespace WebCore" from TextTrackRepresentationCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=214196
Summary
Removing usage of "using namespace WebCore" from TextTrackRepresentationCocoa.mm
frankhome61
Reported
2020-07-10 13:57:56 PDT
Removing the usage of using namespace WebCore from TextTrackRepresentationCocoa.mm, replace it with WebCore:: prefix, and use namespace WebCore { } block for C++ function implementations. This is to avoid potential namespace errors caused by unified source.
Attachments
Patch
(4.10 KB, patch)
2020-07-10 14:05 PDT
,
frankhome61
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-07-10 13:58:35 PDT
<
rdar://problem/65362349
>
frankhome61
Comment 2
2020-07-10 14:05:12 PDT
Created
attachment 403999
[details]
Patch
EWS
Comment 3
2020-07-10 14:58:00 PDT
Committed
r264241
: <
https://trac.webkit.org/changeset/264241
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 403999
[details]
.
Simon Fraser (smfr)
Comment 4
2020-07-10 15:08:50 PDT
Comment on
attachment 403999
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=403999&action=review
> Source/WebCore/ChangeLog:13 > + No new tests are requied as this is a code style fix
required
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug