Bug 214187 - [WebXR] Retrieve supported reference spaces from actual XR systems
Summary: [WebXR] Retrieve supported reference spaces from actual XR systems
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks: 208988
  Show dependency tree / graph
 
Reported: 2020-07-10 07:52 PDT by Sergio Villar Senin
Modified: 2020-07-31 02:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (14.86 KB, patch)
2020-07-10 08:06 PDT, Sergio Villar Senin 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2020-07-10 07:52:12 PDT 
[WebXR] Retrieve supported reference spaces from actual XR systems
Comment 1 Sergio Villar Senin 2020-07-10 08:06:16 PDT 
Created attachment 403967 [details]
Patch
Comment 2 Carlos Garcia Campos 2020-07-15 06:40:52 PDT 
Comment on attachment 403967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403967&action=review

> Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:178
> +    createInfo.enabledExtensionCount = sizeof(enabledExtensions) / sizeof(char*);

WTF_ARRAY_LENGTH?
Comment 3 Radar WebKit Bug Importer 2020-07-20 16:03:51 PDT 
<rdar://problem/65852973>
Comment 4 Nikolas Zimmermann 2020-07-28 04:34:44 PDT 
What's the status here?
Comment 5 Sergio Villar Senin 2020-07-31 01:53:26 PDT 
(In reply to Nikolas Zimmermann from comment #4)
> What's the status here?

I just need to update the patch & land. Got reviewed during my holidays.
Comment 6 Sergio Villar Senin 2020-07-31 02:01:02 PDT 
Committed r265137: <https://trac.webkit.org/changeset/265137>