[WebGL] REGRESSION (r262366): Google search photos do not render, black images
<rdar://problem/64964922>
Created attachment 403906 [details] Patch
Comment on attachment 403906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403906&action=review I think you should be able to write a pretty simple ref test for this. <canvas> <div></div> draw into canvas element canvas.remove(); divElement.appendChild(canvas); > Source/WebCore/html/HTMLCanvasElement.cpp:1014 > + if (insertionType.connectedToDocument) > + addObserver(parentOfInsertedTree.document()); Can it be our document() at this point? I expect this is called after the insertion has happened.
Comment on attachment 403906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403906&action=review > Source/WebCore/html/HTMLCanvasElement.cpp:1011 > +Node::InsertedIntoAncestorResult HTMLCanvasElement::insertedIntoAncestor(InsertionType insertionType, ContainerNode& parentOfInsertedTree) The cool kids write this as auto HTMLCanvasElement::insertedIntoAncestor(InsertionType insertionType, ContainerNode& parentOfInsertedTree) -> InsertedIntoAncestorResult
Created attachment 404030 [details] Patch
Comment on attachment 403906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403906&action=review >> Source/WebCore/html/HTMLCanvasElement.cpp:1011 >> +Node::InsertedIntoAncestorResult HTMLCanvasElement::insertedIntoAncestor(InsertionType insertionType, ContainerNode& parentOfInsertedTree) > > The cool kids write this as auto HTMLCanvasElement::insertedIntoAncestor(InsertionType insertionType, ContainerNode& parentOfInsertedTree) -> InsertedIntoAncestorResult Why? Just to avoid Node::?
Created attachment 404215 [details] Patch for landing
Wrote a ref test, but could not get it to play nice with WebKitTestRunner. Upon advice, skipping the test for now.
Committed r264334: <https://trac.webkit.org/changeset/264334> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404215 [details].