Bug 214140 - [MSE][GStreamer] Inline MediaSourceClientGStreamerMSE away
Summary: [MSE][GStreamer] Inline MediaSourceClientGStreamerMSE away
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-09 08:39 PDT by Alicia Boya García
Modified: 2020-07-10 01:01 PDT (History)
16 users (show)

See Also:

Attachments
Patch (29.75 KB, patch)
2020-07-09 09:28 PDT, Alicia Boya García 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2020-07-09 08:39:04 PDT 
MediaSourceClientGStreamerMSE is a superfluous class that adds
a layer of indirection and complexity to the GStreamer MSE codebase
for no gain. This patch gets rid of it.

This also gets rid of the friend access layer violations that
MediaSourceClientGStreamerMSE relied upon.

This patch is a refactor that doesn't introduce behavior changes and
it's covered by existing tests.
Comment 1 Alicia Boya García 2020-07-09 09:28:07 PDT 
Created attachment 403874 [details]
Patch
Comment 2 EWS 2020-07-10 01:01:11 PDT 
Committed r264211: <https://trac.webkit.org/changeset/264211>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403874 [details].