RESOLVED FIXED 214129
Local internal builds fail on Apple Silicon (building yasm) 
https://bugs.webkit.org/show_bug.cgi?id=214129
Summary Local internal builds fail on Apple Silicon (building yasm)
Tim Horton
Reported 2020-07-09 05:03:54 PDT
Local internal builds fail on Apple Silicon (building yasm)
Attachments
Patch (2.37 KB, patch)
2020-07-09 05:04 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (2.36 KB, patch)
2020-07-09 10:41 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2020-07-09 05:04:20 PDT
Created attachment 403856 [details] Patch
mitz
Comment 2 2020-07-09 06:48:57 PDT
Comment on attachment 403856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403856&action=review > Tools/Scripts/webkitdirs.pm:375 > + if (isAppleCocoaWebKit() && $output eq "arm64") { Could combine with the above into one `if (isAppleCocoaWebKit())` block. > Tools/Scripts/webkitdirs.pm:376 > + $output = determineXcodeSDK(); Why are we assigning an SDK identifier to `$output` (which appears to hold an architecture) here?
Tim Horton
Comment 3 2020-07-09 10:14:10 PDT
Comment on attachment 403856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403856&action=review >> Tools/Scripts/webkitdirs.pm:375 >> + if (isAppleCocoaWebKit() && $output eq "arm64") { > > Could combine with the above into one `if (isAppleCocoaWebKit())` block. I intentionally did not because the above block will go away and this one won’t. >> Tools/Scripts/webkitdirs.pm:376 >> + $output = determineXcodeSDK(); > > Why are we assigning an SDK identifier to `$output` (which appears to hold an architecture) here? Whoops! That was for debugging and I forgot to revert. Good catch.
Tim Horton
Comment 4 2020-07-09 10:41:47 PDT
Created attachment 403887 [details] Patch
EWS
Comment 5 2020-07-09 11:30:05 PDT
Committed r264182: <https://trac.webkit.org/changeset/264182> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403887 [details].
Radar WebKit Bug Importer
Comment 6 2020-07-09 11:31:14 PDT
<rdar://problem/65281288>
Jonathan Bedard
Comment 7 2020-07-10 06:01:49 PDT
Comment on attachment 403887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403887&action=review > Tools/Scripts/webkitdirs.pm:381 > + We need to make sure that run-javascriptcore-tests will override arm64e with arm64. I think it already does, but I don’t have a checkout handy.
Note You need to log in before you can comment on or make changes to this bug.