Bug 214122 – REGRESSION (r259840): Pressing Esc or ⌘+"." does not dismiss time picker on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Wenson Hsieh]

<rdar://problem/64940487>

[Wenson Hsieh]

Created attachment 403898 [details]
Patch

[Tim Horton]

Comment on attachment 403898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403898&action=review

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:379
> +    if (elementType == InputType::Time || elementType == InputType::DateTimeLocal)

I know this was already here... but is there a better way to know or infer the right set of types, instead of keeping a list here?

[Wenson Hsieh]

Comment on attachment 403898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403898&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:379
>> +    if (elementType == InputType::Time || elementType == InputType::DateTimeLocal)
> 
> I know this was already here... but is there a better way to know or infer the right set of types, instead of keeping a list here?

That’s a good question. I don’t think there’s a way to know without poking around in UIKit internals, because the thing that actually steals FR in these controls is _UIDatePickerCalendarTimeLabel (an internal class).

I think we could maybe make this consult -[UIDatePicker datePickerMode] and -[UIDatePicker datePickerStyle] instead, but the logic would look pretty similar to what we have already.

[Tim Horton]

Maybe in the distant future we could ask UIKit to vend an explicit bit for this.

[Wenson Hsieh]

Comment on attachment 403898 [details]
Patch

(In reply to Tim Horton from comment #4)
> Maybe in the distant future we could ask UIKit to vend an explicit bit for
> this.

👍🏻

[EWS]

Committed r264187: <https://trac.webkit.org/changeset/264187>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403898 [details].