Bug 214120 - [iOS] Occasional crash under -[UIView _setViewDelegate:] when presenting date and time pickers
Summary: [iOS] Occasional crash under -[UIView _setViewDelegate:] when presenting date...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-08 20:58 PDT by Wenson Hsieh
Modified: 2020-07-09 08:15 PDT (History)
9 users (show)

See Also:


Attachments
Patch (18.76 KB, patch)
2020-07-08 21:19 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-07-08 20:58:28 PDT
<rdar://problem/65246918>
Comment 1 Wenson Hsieh 2020-07-08 21:19:20 PDT
Created attachment 403843 [details]
Patch
Comment 2 Darin Adler 2020-07-08 22:33:22 PDT
Comment on attachment 403843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403843&action=review

> Source/WebKit/ChangeLog:31
> +        Make it possible to test date and time picker presentation and dismissal by calling into the private testing-

These testing hooks seem a little complicated in their own right. Wish there was a more straightforward pattern.
Comment 3 Wenson Hsieh 2020-07-09 08:13:05 PDT
Comment on attachment 403843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403843&action=review

>> Source/WebKit/ChangeLog:31
>> +        Make it possible to test date and time picker presentation and dismissal by calling into the private testing-
> 
> These testing hooks seem a little complicated in their own right. Wish there was a more straightforward pattern.

Yes! I think that ideally, we’d want to limit this kind of test-specific logic to the actual testing harness (WebKitTestRunner) as much as possible, but it’s tricky here because WKTR can’t really get at the context menu interaction or listen for its delegate methods.

Maybe a simpler, polling-based approach would be more maintainable in the long run...
Comment 4 EWS 2020-07-09 08:15:34 PDT
Committed r264170: <https://trac.webkit.org/changeset/264170>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403843 [details].