Bug 21411 - ResourceHandleInternal.h uses NS class without C++ declaration
Summary: ResourceHandleInternal.h uses NS class without C++ declaration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-06 14:13 PDT by Jeremy Moskovich
Modified: 2008-10-06 18:05 PDT (History)
0 users

See Also:

Attachments
Add forward declaration (1.21 KB, patch)
2008-10-06 14:17 PDT, Jeremy Moskovich 		mitz: review+
Details | Formatted Diff | Diff
Add email address to changelog. (1.19 KB, patch)
2008-10-06 14:26 PDT, Jeremy Moskovich 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Moskovich 2008-10-06 14:13:04 PDT 
ResourceHandleInternal.h is included from ResourceHandle.cpp so it should be a valid C++ header.

However, contains a NSURLAuthenticationChallenge without a C++ compatible forward declaration.
Comment 1 Jeremy Moskovich 2008-10-06 14:17:03 PDT 
Created attachment 24122 [details]
Add forward declaration
Comment 2 mitz 2008-10-06 14:24:03 PDT 
Comment on attachment 24122 [details]
Add forward declaration

r=me
Comment 3 mitz 2008-10-06 14:24:45 PDT 
(In reply to comment #2)
> (From update of attachment 24122 [details] [edit])
> r=me

But please fix
+2008-10-06  Jeremy Moskovich  <set EMAIL_ADDRESS environment variable>
Comment 4 Jeremy Moskovich 2008-10-06 14:26:49 PDT 
Created attachment 24123 [details]
Add email address to changelog.
Comment 5 mitz 2008-10-06 14:28:22 PDT 
Comment on attachment 24123 [details]
Add email address to changelog.

r=me again
Comment 6 Eric Seidel (no email) 2008-10-06 18:05:46 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/network/ResourceHandleInternal.h
Committed r37357