Bug 214096 - Make a logging channel for ScrollSnap and improve its logging
Summary: Make a logging channel for ScrollSnap and improve its logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-08 13:21 PDT by Simon Fraser (smfr)
Modified: 2020-07-08 14:42 PDT (History)
10 users (show)

See Also:


Attachments
Patch (15.81 KB, patch)
2020-07-08 13:22 PDT, Simon Fraser (smfr)
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-07-08 13:21:32 PDT
Make a logging channel for ScrollSnap and improve its logging
Comment 1 Simon Fraser (smfr) 2020-07-08 13:22:41 PDT
Created attachment 403805 [details]
Patch
Comment 2 Wenson Hsieh 2020-07-08 13:24:25 PDT
Comment on attachment 403805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403805&action=review

> Source/WebCore/platform/cocoa/ScrollSnapAnimatorState.mm:123
> +        ts.dumpProperty("snap offsets ranges x", state.snapOffsetRangesForAxis(ScrollEventAxis::Vertical));

This should say “y"
Comment 3 Simon Fraser (smfr) 2020-07-08 14:41:07 PDT
https://trac.webkit.org/changeset/264134/webkit
Comment 4 Radar WebKit Bug Importer 2020-07-08 14:42:17 PDT
<rdar://problem/65241839>