Bug 214083 - [MSE][GStreamer] Make duration changes one way
Summary: [MSE][GStreamer] Make duration changes one way
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-08 08:35 PDT by Alicia Boya García
Modified: 2020-07-09 04:20 PDT (History)
14 users (show)

See Also:


Attachments
Patch (5.84 KB, patch)
2020-07-08 08:46 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2020-07-08 08:35:41 PDT
Until now, AppendPipeline emitted duration changes for the
MediaSource. This was done with
MediaSourcePrivateClient::durationChanged(const MediaTime&), a
method which was added to MediaSource in r207889 just to implement
this in the GStreamer port.

This is not necessary though. AppendPipeline only needs to inform
MediaSource of the duration of the initialization segment, and
MediaSource will in turn set duration from the multi-platform code.

This patch removes MediaSourcePrivateClient::durationChanged(const
MediaTime&) from the multi-platform API, along with its usages in the
GStreamer port, giving the multi-platform code sole responsibility on
duration changes.

This is a code cleanup and it's covered by existing tests.
Comment 1 Alicia Boya García 2020-07-08 08:46:00 PDT
Created attachment 403783 [details]
Patch
Comment 2 Enrique Ocaña 2020-07-08 09:43:54 PDT
I agree with the change.

This was something suggested by Jer Noble on https://bugs.webkit.org/show_bug.cgi?id=162920#c5, so it's great to have it implemented in this patch.
Comment 3 EWS 2020-07-09 04:20:13 PDT
Committed r264164: <https://trac.webkit.org/changeset/264164>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403783 [details].