Bug 214059 - [Cocoa] Fix adjust-angle-include-paths.sh error seen building ANGLE library
Summary: [Cocoa] Fix adjust-angle-include-paths.sh error seen building ANGLE library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-07 14:26 PDT by Darin Adler
Modified: 2020-07-08 10:57 PDT (History)
7 users (show)

See Also:


Attachments
Patch (13.37 KB, patch)
2020-07-07 14:27 PDT, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-07-07 14:26:59 PDT
Fix adjust-angle-include-paths.sh error seen building ANGLE library
Comment 1 Darin Adler 2020-07-07 14:27:46 PDT
Created attachment 403726 [details]
Patch
Comment 2 EWS Watchlist 2020-07-07 15:13:54 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Alexey Proskuryakov 2020-07-07 18:22:43 PDT
Comment on attachment 403726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403726&action=review

rs=me if Dean says so!

> Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj:-4276
> -			outputFileListPaths = (
> -			);
> -			outputPaths = (
> -			);

Hmm, do we have the same for dynamic library target? No dependencies - bad for XCBuild.
Comment 4 Keith Rollin 2020-07-07 18:46:24 PDT
XCBuild doesn't use this Run Script build phase, so it's OK if there are no dependencies. Instead, the copy-and-mutate-header-files is done in the Copy Headers build phase.
Comment 5 EWS 2020-07-08 10:56:38 PDT
Committed r264116: <https://trac.webkit.org/changeset/264116>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403726 [details].
Comment 6 Radar WebKit Bug Importer 2020-07-08 10:57:36 PDT
<rdar://problem/65231817>